agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Amit Langote <amitlan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Attempt to fix test interference from foreign_key opfamily test
Date: Sun, 20 Sep 2026 05:17:07 +0000
Message-ID: <E1x89vH-00000000Tqv-3JY2@gemulon.postgresql.org> (raw)
Attempt to fix test interference from foreign_key opfamily test
The test added by c62b330912e creates a btree opfamily whose members
include built-in integer operators, which get_mergejoin_opfamilies()
finds regardless of schema. So any concurrently running test that
planned an integer join or sort could pick the family up while it
existed. That's the likely cause of the intermittent plan-shape
changes seen in window.sql and equivclass.sql on the buildfarm after
that commit.
Run the test inside a transaction that is rolled back, so the family
is never committed and never visible to other backends.
Per buildfarm members sifaka, prion, turaca, widowbird.
Discussion: https://postgr.es/m/CA+HiwqGitHCmO7nvV4nXXYWDkNYA+zVcJj=JNmL3C1O9B0Gz0A@mail.gmail.com
Backpatch-though: 19
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/f76c13edadc2b319036e0d238703ed56bb23f934
Modified Files
--------------
src/test/regress/expected/foreign_key.out | 19 +++++++++++--------
src/test/regress/sql/foreign_key.sql | 19 +++++++++++--------
2 files changed, 22 insertions(+), 16 deletions(-)
view thread (2+ messages) latest in thread
Message-ID: <E1x89vH-00000000Tqv-3JY2@gemulon.postgresql.org>
Permalink: ../E1x89vH-00000000Tqv-3JY2@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x89vH-00000000Tqv-3JY2@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: amitlan@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Attempt to fix test interference from foreign_key opfamily test
In-Reply-To: <E1x89vH-00000000Tqv-3JY2@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox