agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Fix alignas placement in GinTuple 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix alignas placement in GinTuple @ 2026-09-23 07:32 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 2+ messages in thread From: Peter Eisentraut @ 2026-09-23 07:32 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix alignas placement in GinTuple Commit bad8829872d added an alignas specifier, and placed it in the middle of the declaration, unlike most existing uses, possibly to avoid the indentation problem recently fixed in commit 884f82ae262. This placement is valid in C but not in C++, which requires it to be at the beginning. This results in a warning in g++ and an error in clang++. Fix by moving it accordingly. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/9bfdcfbfcf98f819a5f7f35fa3dee25bcf96b3a5 Modified Files -------------- src/include/access/gin_tuple.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix alignas placement in GinTuple @ 2026-09-23 07:32 Peter Eisentraut <peter@eisentraut.org> 0 siblings, 0 replies; 2+ messages in thread From: Peter Eisentraut @ 2026-09-23 07:32 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix alignas placement in GinTuple Commit 05c4b10fc52 added an alignas specifier, and placed it in the middle of the declaration, unlike most existing uses, possibly to avoid the indentation problem recently fixed in commit 884f82ae262. This placement is valid in C but not in C++, which requires it to be at the beginning. This results in a warning in g++ and an error in clang++. Fix by moving it accordingly. The fix for the indentation problem has been backpatched to support this patch. Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/f89a5c086f8a2837ee122b3e3631f0b41a3a7865 Modified Files -------------- src/include/access/gin_tuple.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-09-23 07:32 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-09-23 07:32 pgsql: Fix alignas placement in GinTuple Peter Eisentraut <peter@eisentraut.org> 2026-09-23 07:32 pgsql: Fix alignas placement in GinTuple Peter Eisentraut <peter@eisentraut.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox