agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix alignas placement in GinTuple
Date: Wed, 23 Sep 2026 07:32:22 +0000
Message-ID: <E1x9HSo-00000000sjT-21BU@gemulon.postgresql.org> (raw)

Fix alignas placement in GinTuple

Commit 05c4b10fc52 added an alignas specifier, and placed it in the
middle of the declaration, unlike most existing uses, possibly to
avoid the indentation problem recently fixed in commit 884f82ae262.
This placement is valid in C but not in C++, which requires it to be
at the beginning.  This results in a warning in g++ and an error in
clang++.  Fix by moving it accordingly.  The fix for the indentation
problem has been backpatched to support this patch.

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f89a5c086f8a2837ee122b3e3631f0b41a3a7865

Modified Files
--------------
src/include/access/gin_tuple.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



view thread (2+ messages)

Message-ID: <E1x9HSo-00000000sjT-21BU@gemulon.postgresql.org>
Permalink:  ../E1x9HSo-00000000sjT-21BU@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1x9HSo-00000000sjT-21BU@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix alignas placement in GinTuple
  In-Reply-To: <E1x9HSo-00000000sjT-21BU@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox