agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Dean Rasheed <dean.a.rasheed@gmail.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix concurrent delete handling in MERGE ... WHEN NOT MATCHED BY
Date: Wed, 23 Sep 2026 08:41:40 +0000
Message-ID: <E1x9IXs-00000000tF2-3xqQ@gemulon.postgresql.org> (raw)
Fix concurrent delete handling in MERGE ... WHEN NOT MATCHED BY SOURCE.
When executing a WHEN NOT MATCHED BY SOURCE action in MERGE, if the
tuple from the target table was concurrently deleted, the retry code
would incorrectly execute a WHEN NOT MATCHED BY TARGET action for the
row instead, giving incorrect results.
Fix in ExecMergeMatched() -- when handling a TM_Deleted failure
status, it should only set *matched to false (telling the caller to
execute any WHEN NOT MATCHED BY TARGET actions) if the failed action
was a WHEN MATCHED action. For a failed WHEN NOT MATCHED BY SOURCE
action, the source tuple did not exist, and the target tuple has just
been deleted, so it should do nothing.
Back-patch to v17, where support for WHEN NOT MATCHED BY SOURCE
actions was introduced.
Reported-by: Jeff Davis <pgsql@j-davis.com>
Author: Tender Wang <tndrwang@gmail.com>
Reviewed-by: Dean Rasheed <dean.a.rasheed@gmail.com>
Discussion: https://postgr.es/m/ccdab5ba02c65af195b5a6d2d744a01d9de47cd3.camel@j-davis.com
Backpatch-through: 17
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/745152e451c10ff8635b0f0f186de98fe0528fec
Modified Files
--------------
src/backend/executor/nodeModifyTable.c | 35 ++++--
src/test/isolation/expected/merge-delete.out | 158 +++++++++++++++++++++++++++
src/test/isolation/specs/merge-delete.spec | 37 +++++++
3 files changed, 220 insertions(+), 10 deletions(-)
view thread (4+ messages)
Message-ID: <E1x9IXs-00000000tF2-3xqQ@gemulon.postgresql.org>
Permalink: ../E1x9IXs-00000000tF2-3xqQ@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x9IXs-00000000tF2-3xqQ@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: dean.a.rasheed@gmail.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix concurrent delete handling in MERGE ... WHEN NOT MATCHED BY
In-Reply-To: <E1x9IXs-00000000tF2-3xqQ@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox