agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Fix assertion in pg_get_shmem_pagesize() in single-user mode 3+ messages / 1 participants [nested] [flat]
* pgsql: Fix assertion in pg_get_shmem_pagesize() in single-user mode @ 2026-09-24 11:50 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 3+ messages in thread From: Heikki Linnakangas @ 2026-09-24 11:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix assertion in pg_get_shmem_pagesize() in single-user mode Remove assertion that was too strict, and tripped if you queried the pg_shmem_allocations_numa or the pg_buffercache_os_pages view in single-user mode. The point of the assertion was that the function should only be called after "the server has started", but it would be OK to call it from the postmaster, too, as long as it's after startup, specifically after huge_pages_status has been set. We already have a direct assertion for that. Author: Ayush Tiwari <ayushtiwari.slg01@gmail.com> Discussion: https://www.postgresql.org/message-id/CAJTYsWV-=w5_oFgCnfAixWGc=gMa2pkDinLyGLsb4sKcDaf2FA@mail.gmail... Backpatch-through: 18 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/89829354de1b5f3f8cb3dbdd2f2fc087f981a1b3 Modified Files -------------- src/backend/storage/ipc/shmem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix assertion in pg_get_shmem_pagesize() in single-user mode @ 2026-09-24 11:50 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 3+ messages in thread From: Heikki Linnakangas @ 2026-09-24 11:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix assertion in pg_get_shmem_pagesize() in single-user mode Remove assertion that was too strict, and tripped if you queried the pg_shmem_allocations_numa or the pg_buffercache_os_pages view in single-user mode. The point of the assertion was that the function should only be called after "the server has started", but it would be OK to call it from the postmaster, too, as long as it's after startup, specifically after huge_pages_status has been set. We already have a direct assertion for that. Author: Ayush Tiwari <ayushtiwari.slg01@gmail.com> Discussion: https://www.postgresql.org/message-id/CAJTYsWV-=w5_oFgCnfAixWGc=gMa2pkDinLyGLsb4sKcDaf2FA@mail.gmail... Backpatch-through: 18 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/dae3463fa969931458f1488f9b7af11e3741cd54 Modified Files -------------- src/backend/storage/ipc/shmem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix assertion in pg_get_shmem_pagesize() in single-user mode @ 2026-09-24 11:50 Heikki Linnakangas <heikki.linnakangas@iki.fi> 0 siblings, 0 replies; 3+ messages in thread From: Heikki Linnakangas @ 2026-09-24 11:50 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix assertion in pg_get_shmem_pagesize() in single-user mode Remove assertion that was too strict, and tripped if you queried the pg_shmem_allocations_numa or the pg_buffercache_os_pages view in single-user mode. The point of the assertion was that the function should only be called after "the server has started", but it would be OK to call it from the postmaster, too, as long as it's after startup, specifically after huge_pages_status has been set. We already have a direct assertion for that. Author: Ayush Tiwari <ayushtiwari.slg01@gmail.com> Discussion: https://www.postgresql.org/message-id/CAJTYsWV-=w5_oFgCnfAixWGc=gMa2pkDinLyGLsb4sKcDaf2FA@mail.gmail... Backpatch-through: 18 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/297eb6a04f870f6b1f7c15cd710dc2f30a8776e3 Modified Files -------------- src/backend/storage/ipc/shmem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2026-09-24 11:50 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-09-24 11:50 pgsql: Fix assertion in pg_get_shmem_pagesize() in single-user mode Heikki Linnakangas <heikki.linnakangas@iki.fi> 2026-09-24 11:50 pgsql: Fix assertion in pg_get_shmem_pagesize() in single-user mode Heikki Linnakangas <heikki.linnakangas@iki.fi> 2026-09-24 11:50 pgsql: Fix assertion in pg_get_shmem_pagesize() in single-user mode Heikki Linnakangas <heikki.linnakangas@iki.fi>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox