agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix assertion in pg_get_shmem_pagesize() in single-user mode
Date: Thu, 24 Sep 2026 11:50:12 +0000
Message-ID: <E1x9hxs-000000013br-3sHc@gemulon.postgresql.org> (raw)
Fix assertion in pg_get_shmem_pagesize() in single-user mode
Remove assertion that was too strict, and tripped if you queried the
pg_shmem_allocations_numa or the pg_buffercache_os_pages view in
single-user mode.
The point of the assertion was that the function should only be called
after "the server has started", but it would be OK to call it from the
postmaster, too, as long as it's after startup, specifically after
huge_pages_status has been set. We already have a direct assertion
for that.
Author: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Discussion: https://www.postgresql.org/message-id/CAJTYsWV-=w5_oFgCnfAixWGc=gMa2pkDinLyGLsb4sKcDaf2FA@mail.gmail...
Backpatch-through: 18
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/dae3463fa969931458f1488f9b7af11e3741cd54
Modified Files
--------------
src/backend/storage/ipc/shmem.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
view thread (3+ messages) latest in thread
Message-ID: <E1x9hxs-000000013br-3sHc@gemulon.postgresql.org>
Permalink: ../E1x9hxs-000000013br-3sHc@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x9hxs-000000013br-3sHc@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: heikki.linnakangas@iki.fi, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix assertion in pg_get_shmem_pagesize() in single-user mode
In-Reply-To: <E1x9hxs-000000013br-3sHc@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox