agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Suppress -Wshadow=local warnings in REG_DEBUG code.
Date: Thu, 24 Sep 2026 17:28:21 +0000
Message-ID: <E1x9nF7-000000015se-1O25@gemulon.postgresql.org> (raw)
Suppress -Wshadow=local warnings in REG_DEBUG code.
Our Solaris-camp buildfarm animals (billbug, hake, pollock, so far)
are complaining about dumpcolors()'s local variables in the wake of
3ee0edb91. This is unsurprising on one level, since that code
clearly violates the new expectation; but AFAICS these animals
aren't explicitly enabling -DREG_DEBUG, so how are they reaching
the now-faulty code? Do Solaris' headers #define that?
In any case, the fix is simple enough, just narrow the
declaration scopes of this function's loop variables.
(I could have done that only to "c", but thought it best
to maintain a consistent style in this function.)
I don't see any need to back-patch this.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/92616429093e16f938aeca92e1045174835c2a8d
Modified Files
--------------
src/backend/regex/regc_color.c | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
Message-ID: <E1x9nF7-000000015se-1O25@gemulon.postgresql.org>
Permalink: ../E1x9nF7-000000015se-1O25@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1x9nF7-000000015se-1O25@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Suppress -Wshadow=local warnings in REG_DEBUG code.
In-Reply-To: <E1x9nF7-000000015se-1O25@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox