agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Don't emit garbage "\[un]restrict (null)" commands in pg_dump. 7+ messages / 1 participants [nested] [flat]
* pgsql: Don't emit garbage "\[un]restrict (null)" commands in pg_dump. @ 2026-09-26 16:56 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2026-09-26 16:56 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't emit garbage "\[un]restrict (null)" commands in pg_dump. _reconnectToDB() failed to consider the possibility that it could be called without any restrict_key set. This is reachable while generating the "restore.sql" file in tar dump mode, which nobody noticed because that file is mostly unused (and nothing really bad happens anyway unless you specified --inserts mode). But I wonder if there are other code paths that reach the issue. Bug: #19718 Reported-by: Pavel Kopylov <pkopylov@cloudlinux.com> Author: Pavel Kopylov <pkopylov@cloudlinux.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/19718-7e945d0ff9b5a589@postgresql.org Backpatch-through: 14 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/3c5d9d914fa5b8fb3f371dd97bdece032ca3598d Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Don't emit garbage "\[un]restrict (null)" commands in pg_dump. @ 2026-09-26 16:56 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2026-09-26 16:56 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't emit garbage "\[un]restrict (null)" commands in pg_dump. _reconnectToDB() failed to consider the possibility that it could be called without any restrict_key set. This is reachable while generating the "restore.sql" file in tar dump mode, which nobody noticed because that file is mostly unused (and nothing really bad happens anyway unless you specified --inserts mode). But I wonder if there are other code paths that reach the issue. Bug: #19718 Reported-by: Pavel Kopylov <pkopylov@cloudlinux.com> Author: Pavel Kopylov <pkopylov@cloudlinux.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/19718-7e945d0ff9b5a589@postgresql.org Backpatch-through: 14 Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/054eb938e51f4779f3fa4a9c2ed882a49a2cb941 Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Don't emit garbage "\[un]restrict (null)" commands in pg_dump. @ 2026-09-26 16:56 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2026-09-26 16:56 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't emit garbage "\[un]restrict (null)" commands in pg_dump. _reconnectToDB() failed to consider the possibility that it could be called without any restrict_key set. This is reachable while generating the "restore.sql" file in tar dump mode, which nobody noticed because that file is mostly unused (and nothing really bad happens anyway unless you specified --inserts mode). But I wonder if there are other code paths that reach the issue. Bug: #19718 Reported-by: Pavel Kopylov <pkopylov@cloudlinux.com> Author: Pavel Kopylov <pkopylov@cloudlinux.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/19718-7e945d0ff9b5a589@postgresql.org Backpatch-through: 14 Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/2d748cfe337ec5afab3863f733caca43333c89cf Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Don't emit garbage "\[un]restrict (null)" commands in pg_dump. @ 2026-09-26 16:56 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2026-09-26 16:56 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't emit garbage "\[un]restrict (null)" commands in pg_dump. _reconnectToDB() failed to consider the possibility that it could be called without any restrict_key set. This is reachable while generating the "restore.sql" file in tar dump mode, which nobody noticed because that file is mostly unused (and nothing really bad happens anyway unless you specified --inserts mode). But I wonder if there are other code paths that reach the issue. Bug: #19718 Reported-by: Pavel Kopylov <pkopylov@cloudlinux.com> Author: Pavel Kopylov <pkopylov@cloudlinux.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/19718-7e945d0ff9b5a589@postgresql.org Backpatch-through: 14 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/45fc3ce22482ec50c0e1b5817782970bf03dbc0b Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Don't emit garbage "\[un]restrict (null)" commands in pg_dump. @ 2026-09-26 16:56 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2026-09-26 16:56 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't emit garbage "\[un]restrict (null)" commands in pg_dump. _reconnectToDB() failed to consider the possibility that it could be called without any restrict_key set. This is reachable while generating the "restore.sql" file in tar dump mode, which nobody noticed because that file is mostly unused (and nothing really bad happens anyway unless you specified --inserts mode). But I wonder if there are other code paths that reach the issue. Bug: #19718 Reported-by: Pavel Kopylov <pkopylov@cloudlinux.com> Author: Pavel Kopylov <pkopylov@cloudlinux.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/19718-7e945d0ff9b5a589@postgresql.org Backpatch-through: 14 Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c5fcb19d04981f0f3ba420ce1696b5764d9a0e42 Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Don't emit garbage "\[un]restrict (null)" commands in pg_dump. @ 2026-09-26 16:56 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2026-09-26 16:56 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't emit garbage "\[un]restrict (null)" commands in pg_dump. _reconnectToDB() failed to consider the possibility that it could be called without any restrict_key set. This is reachable while generating the "restore.sql" file in tar dump mode, which nobody noticed because that file is mostly unused (and nothing really bad happens anyway unless you specified --inserts mode). But I wonder if there are other code paths that reach the issue. Bug: #19718 Reported-by: Pavel Kopylov <pkopylov@cloudlinux.com> Author: Pavel Kopylov <pkopylov@cloudlinux.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/19718-7e945d0ff9b5a589@postgresql.org Backpatch-through: 14 Branch ------ REL_15_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/b349762fdeb7193b55fd1ae44a2e79903f13b14a Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Don't emit garbage "\[un]restrict (null)" commands in pg_dump. @ 2026-09-26 16:56 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 7+ messages in thread From: Tom Lane @ 2026-09-26 16:56 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Don't emit garbage "\[un]restrict (null)" commands in pg_dump. _reconnectToDB() failed to consider the possibility that it could be called without any restrict_key set. This is reachable while generating the "restore.sql" file in tar dump mode, which nobody noticed because that file is mostly unused (and nothing really bad happens anyway unless you specified --inserts mode). But I wonder if there are other code paths that reach the issue. Bug: #19718 Reported-by: Pavel Kopylov <pkopylov@cloudlinux.com> Author: Pavel Kopylov <pkopylov@cloudlinux.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/19718-7e945d0ff9b5a589@postgresql.org Backpatch-through: 14 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ae63671a7fb1c297c39027e0b29e6bed8d8aa5e2 Modified Files -------------- src/bin/pg_dump/pg_backup_archiver.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2026-09-26 16:56 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-09-26 16:56 pgsql: Don't emit garbage "\[un]restrict (null)" commands in pg_dump. Tom Lane <tgl@sss.pgh.pa.us> 2026-09-26 16:56 pgsql: Don't emit garbage "\[un]restrict (null)" commands in pg_dump. Tom Lane <tgl@sss.pgh.pa.us> 2026-09-26 16:56 pgsql: Don't emit garbage "\[un]restrict (null)" commands in pg_dump. Tom Lane <tgl@sss.pgh.pa.us> 2026-09-26 16:56 pgsql: Don't emit garbage "\[un]restrict (null)" commands in pg_dump. Tom Lane <tgl@sss.pgh.pa.us> 2026-09-26 16:56 pgsql: Don't emit garbage "\[un]restrict (null)" commands in pg_dump. Tom Lane <tgl@sss.pgh.pa.us> 2026-09-26 16:56 pgsql: Don't emit garbage "\[un]restrict (null)" commands in pg_dump. Tom Lane <tgl@sss.pgh.pa.us> 2026-09-26 16:56 pgsql: Don't emit garbage "\[un]restrict (null)" commands in pg_dump. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox