agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Don't emit garbage "\[un]restrict (null)" commands in pg_dump.
Date: Sat, 26 Sep 2026 16:56:41 +0000
Message-ID: <E1xAVhZ-00000001N3E-3M3r@gemulon.postgresql.org> (raw)
Don't emit garbage "\[un]restrict (null)" commands in pg_dump.
_reconnectToDB() failed to consider the possibility that it could
be called without any restrict_key set. This is reachable while
generating the "restore.sql" file in tar dump mode, which nobody
noticed because that file is mostly unused (and nothing really
bad happens anyway unless you specified --inserts mode). But
I wonder if there are other code paths that reach the issue.
Bug: #19718
Reported-by: Pavel Kopylov <pkopylov@cloudlinux.com>
Author: Pavel Kopylov <pkopylov@cloudlinux.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/19718-7e945d0ff9b5a589@postgresql.org
Backpatch-through: 14
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/b349762fdeb7193b55fd1ae44a2e79903f13b14a
Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
view thread (7+ messages) latest in thread
Message-ID: <E1xAVhZ-00000001N3E-3M3r@gemulon.postgresql.org>
Permalink: ../E1xAVhZ-00000001N3E-3M3r@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1xAVhZ-00000001N3E-3M3r@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Don't emit garbage "\[un]restrict (null)" commands in pg_dump.
In-Reply-To: <E1xAVhZ-00000001N3E-3M3r@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox