pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add table to regression tests for binary-compatibility checks in
Date: Thu, 18 Nov 2021 11:19:30 +0900
Message-ID: <YZW4MvzCZ+hQ34vw@paquier.xyz> (raw)
In-Reply-To: <E1mnWNi-0002SA-LH@gemulon.postgresql.org>
References: <E1mnWNi-0002SA-LH@gemulon.postgresql.org>

On Thu, Nov 18, 2021 at 01:38:30AM +0000, Michael Paquier wrote:
> Add table to regression tests for binary-compatibility checks in pg_upgrade
> 
> This commit adds to the main regression test suite a table with all
> the in-core data types (some exceptions apply).  This table is not
> dropped, so as pg_upgrade would be able to check the binary
> compatibility of the types tracked in the table.  If a new type is added
> in core, this part of the tests would need a refresh but the tests are
> designed to fail if that were to happen.

prion has been failing in a fancy way:
   arraymultirange(arrayrange(ARRAY[1,2], ARRAY[2,1]));
+ERROR:  unrecognized key word: "ec2"
+HINT:  ACL key word must be "group" or "user".

That's an environment-related issue, as the user name of this animal
uses an hyphen "ec2-user", and this is bumping on the generation of
the aclitem.  This is missing some quote_ident()'s, visibly.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (5+ messages)

Message-ID: <YZW4MvzCZ+hQ34vw@paquier.xyz>
Permalink:  ../YZW4MvzCZ+hQ34vw@paquier.xyz/
Also on:    postgresql.org/message-id/YZW4MvzCZ+hQ34vw@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Add table to regression tests for binary-compatibility checks in
  In-Reply-To: <YZW4MvzCZ+hQ34vw@paquier.xyz>
  References: <E1mnWNi-0002SA-LH@gemulon.postgresql.org> <YZW4MvzCZ+hQ34vw@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox