pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-committers@lists.postgresql.org, Andrew Dunstan <andrew@dunslane.net>
Subject: Re: pgsql: Add TAP tests for contrib/sslinfo
Date: Wed, 1 Dec 2021 15:19:10 +0900
Message-ID: <YacT3tm97xziSUFw@paquier.xyz> (raw)
In-Reply-To: <1686601.1638333261@sss.pgh.pa.us>
References: <E1ms0iG-00050P-1G@gemulon.postgresql.org>
	<058AAA2B-06CA-4D1C-8D24-B9EA6632C072@yesql.se>
	<FB603D1D-2F48-48E1-B1BB-4DEF95DAF393@yesql.se>
	<1632478.1638305700@sss.pgh.pa.us>
	<887628C4-6E1C-4DE5-BA8E-4252BA2B1A0D@yesql.se>
	<1636597.1638308177@sss.pgh.pa.us>
	<BF937964-0854-49DA-A4F4-51F4287EB304@yesql.se>
	<1686601.1638333261@sss.pgh.pa.us>

On Tue, Nov 30, 2021 at 11:34:21PM -0500, Tom Lane wrote:
> Daniel Gustafsson <daniel@yesql.se> writes:
> > Oh, interesting, I hadn't realized that. I'll go do that instead then.
> 
> ... okay, so all we learned is that it really is an ENOENT failure.
> 
> At this point my guess is that the test is copying the key file
> to the wrong place because of an MSys path issue.  I don't know
> that topic well enough to debug it, though.

Daniel has pinged me about this issue.  From what I can see, c113d8ad
has changed 001_ssltests.pl so as the keys are not anymore relative
paths with *_tmp* names but absolute paths with the same key name, so
it seems to me that you should sprinkle some perl2host() calls in the
${PostgreSQL::Test::Utils::tmp_check} paths to allow Msys to
understand them.  At quick glance, it looks like this is the first
time we'd pass down absolute paths to libpq within connection
strings in the TAP tests.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (24+ messages)  latest in thread

Message-ID: <YacT3tm97xziSUFw@paquier.xyz>
Permalink:  ../YacT3tm97xziSUFw@paquier.xyz/
Also on:    postgresql.org/message-id/YacT3tm97xziSUFw@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, daniel@yesql.se, andrew@dunslane.net
  Subject: Re: pgsql: Add TAP tests for contrib/sslinfo
  In-Reply-To: <YacT3tm97xziSUFw@paquier.xyz>
  References: <E1ms0iG-00050P-1G@gemulon.postgresql.org> <058AAA2B-06CA-4D1C-8D24-B9EA6632C072@yesql.se> <FB603D1D-2F48-48E1-B1BB-4DEF95DAF393@yesql.se> <1632478.1638305700@sss.pgh.pa.us> <887628C4-6E1C-4DE5-BA8E-4252BA2B1A0D@yesql.se> <1636597.1638308177@sss.pgh.pa.us> <BF937964-0854-49DA-A4F4-51F4287EB304@yesql.se> <1686601.1638333261@sss.pgh.pa.us> <YacT3tm97xziSUFw@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox