pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Jeff Davis <jdavis@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Respect permissions within logical replication.
Date: Sat, 8 Jan 2022 14:22:23 +0900
Message-ID: <Ydkfj5IsZg7mQR0g@paquier.xyz> (raw)
In-Reply-To: <E1n61f6-0006DS-Ek@gemulon.postgresql.org>
References: <E1n61f6-0006DS-Ek@gemulon.postgresql.org>

Hi Jeff,

On Sat, Jan 08, 2022 at 02:40:56AM +0000, Jeff Davis wrote:
> Respect permissions within logical replication.

The buildfarm is not completely happy after this commit:
1) massasauga is failing the new test:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=massasauga&dt=2022-01-08%2002%3A45%3A21
#   Failed test 'superuser admin replicates insert into unpartitioned'
#   at t/027_nosuperuser.pl line 46.
#          got: '2|1|3'
#     expected: '3|1|5'
# Looks like you failed 1 test of 100.

2) crake fails perl-check
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2022-01-08%2002%3A47%3A26

All the failures are the same, because of the shape of the subroutine
definitions:
Jan 07 21:53:04 ./src/test/subscription/t/027_nosuperuser.pl:
Subroutine prototypes used at line 13, column 1.  See page 194 of
PBP.  ([Subroutines::ProhibitSubroutinePrototypes] Severity: 5)

Thanks,
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (7+ messages)  latest in thread

Message-ID: <Ydkfj5IsZg7mQR0g@paquier.xyz>
Permalink:  ../Ydkfj5IsZg7mQR0g@paquier.xyz/
Also on:    postgresql.org/message-id/Ydkfj5IsZg7mQR0g@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, jdavis@postgresql.org
  Subject: Re: pgsql: Respect permissions within logical replication.
  In-Reply-To: <Ydkfj5IsZg7mQR0g@paquier.xyz>
  References: <E1n61f6-0006DS-Ek@gemulon.postgresql.org> <Ydkfj5IsZg7mQR0g@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox