pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: tests: Consistently use pg_basebackup -cfast --no-sync to accele
Date: Tue, 18 Jan 2022 10:18:36 +0900
Message-ID: <YeYVbHXaNfW9kavH@paquier.xyz> (raw)
In-Reply-To: <E1n9bjG-0006Tn-Mj@gemulon.postgresql.org>
References: <E1n9bjG-0006Tn-Mj@gemulon.postgresql.org>

Hi Andres,

On Mon, Jan 17, 2022 at 11:48:02PM +0000, Andres Freund wrote:
> tests: Consistently use pg_basebackup -cfast --no-sync to accelerate tests.
> 
> Most tests invoking pg_basebackup themselves did not yet use -cfast, which
> makes pg_basebackup take considerably longer. The only reason this didn't
> cause the tests to take many minutes is that spread checkpoints only throttle
> when writing out a buffer and there aren't that many dirty buffers in the
> tests...

Are you planning to back-patch any of this?  It seems to me that it
would not hurt, and making the tests faster on back-branches saves
time when working on those branches.

Thanks,
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (3+ messages)  latest in thread

Message-ID: <YeYVbHXaNfW9kavH@paquier.xyz>
Permalink:  ../YeYVbHXaNfW9kavH@paquier.xyz/
Also on:    postgresql.org/message-id/YeYVbHXaNfW9kavH@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, andres@anarazel.de
  Subject: Re: pgsql: tests: Consistently use pg_basebackup -cfast --no-sync to accele
  In-Reply-To: <YeYVbHXaNfW9kavH@paquier.xyz>
  References: <E1n9bjG-0006Tn-Mj@gemulon.postgresql.org> <YeYVbHXaNfW9kavH@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox