pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Database-level collation version tracking
Date: Mon, 14 Feb 2022 17:18:52 +0900
Message-ID: <YgoQbGpnzdTuV8fP@paquier.xyz> (raw)
In-Reply-To: <E1nJVyA-0003tZ-IP@gemulon.postgresql.org>
References: <E1nJVyA-0003tZ-IP@gemulon.postgresql.org>

On Mon, Feb 14, 2022 at 07:40:22AM +0000, Peter Eisentraut wrote:
> Database-level collation version tracking
> 
> This adds to database objects the same version tracking that collation
> objects have.  There is a new pg_database column datcollversion that
> stores the version, a new function
> pg_database_collation_actual_version() to get the version from the
> operating system, and a new subcommand ALTER DATABASE ... REFRESH
> COLLATION VERSION.
> 
> This was not originally added together with pg_collation.collversion,
> since originally version tracking was only supported for ICU, and ICU
> on a database-level is not currently supported.  But we now have
> version tracking for glibc (since PG13), FreeBSD (since PG14), and
> Windows (since PG13), so this is useful to have now.

calliphoridae does not like this one:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=calliphoridae&dt=2022-02-14%2007%3A41%3A...

 SELECT current_database() AS datname \\gset
 ALTER DATABASE :"datname" REFRESH COLLATION VERSION;
-NOTICE:  version has not changed
+ERROR:  unrecognized node type: 291

Worth noting that it uses -DDCOPY_PARSE_PLAN_TREES and
-DRAW_EXPRESSION_COVERAGE_TEST, so you may have missed a piece in this
area.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (3+ messages)  latest in thread

Message-ID: <YgoQbGpnzdTuV8fP@paquier.xyz>
Permalink:  ../YgoQbGpnzdTuV8fP@paquier.xyz/
Also on:    postgresql.org/message-id/YgoQbGpnzdTuV8fP@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, peter@eisentraut.org
  Subject: Re: pgsql: Database-level collation version tracking
  In-Reply-To: <YgoQbGpnzdTuV8fP@paquier.xyz>
  References: <E1nJVyA-0003tZ-IP@gemulon.postgresql.org> <YgoQbGpnzdTuV8fP@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox