pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add option to use ICU as global locale provider
Date: Fri, 18 Mar 2022 11:01:11 +0900
Message-ID: <YjPn5+Y9Gj58PlEW@paquier.xyz> (raw)
In-Reply-To: <E1nUnH5-0006aR-MX@gemulon.postgresql.org>
References: <E1nUnH5-0006aR-MX@gemulon.postgresql.org>

Hi Peter,

On Thu, Mar 17, 2022 at 10:22:32AM +0000, Peter Eisentraut wrote:
> Add option to use ICU as global locale provider
> 
> This adds the option to use ICU as the default locale provider for
> either the whole cluster or a database.  New options for initdb,
> createdb, and CREATE DATABASE are used to select this.
> 
> Since some (legacy) code still uses the libc locale facilities
> directly, we still need to set the libc global locale settings even if
> ICU is otherwise selected.  So pg_database now has three
> locale-related fields: the existing datcollate and datctype, which are
> always set, and a new daticulocale, which is only set if ICU is
> selected.  A similar change is made in pg_collation for consistency,
> but in that case, only the libc-related fields or the ICU-related
> field is set, never both.

FYI, prion is complaining here:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2022-03-18%2001%3A43%3A13

Some details:
#   Failed test 'fails for invalid ICU locale: matches'
#   at t/001_initdb.pl line 107.
#                   '2022-03-18 01:54:58.563 UTC [504] FATAL:  could
#   not open collator for locale "@colNumeric=lower":
#   U_ILLEGAL_ARGUMENT_ERROR
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (22+ messages)  latest in thread

Message-ID: <YjPn5+Y9Gj58PlEW@paquier.xyz>
Permalink:  ../YjPn5+Y9Gj58PlEW@paquier.xyz/
Also on:    postgresql.org/message-id/YjPn5+Y9Gj58PlEW@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, peter@eisentraut.org
  Subject: Re: pgsql: Add option to use ICU as global locale provider
  In-Reply-To: <YjPn5+Y9Gj58PlEW@paquier.xyz>
  References: <E1nUnH5-0006aR-MX@gemulon.postgresql.org> <YjPn5+Y9Gj58PlEW@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox