From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Markus Wanner <markus.wanner@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Subject: Re: API stability [was: pgsql: Fix possible recovery trouble if TRUNCATE overlaps a checkpoint.]
Date: Thu, 7 Apr 2022 15:28:19 +0900
Message-ID: <Yk6Eg2YZ14TDTOPO@paquier.xyz> (raw)
In-Reply-To: <2661153.1649186180@sss.pgh.pa.us>
References: <E1nXTCX-001DGF-R0@gemulon.postgresql.org>
<a7880f4d-1d74-582a-ada7-dad168d046d1@enterprisedb.com>
<CA+TgmoaVwQj_nG-jPB8O=t8=h-QBoF2U+tKviv8BT8unfTEZiw@mail.gmail.com>
<2358496.1649168259@sss.pgh.pa.us>
<CA+Tgmoabm0CHEYE2HpFSopGxrJ3u0edM=Mjx==sWrpdHvQ00qQ@mail.gmail.com>
<2360280.1649169126@sss.pgh.pa.us>
<CA+TgmoZhCYhSOMbmaRjJ1spcd-GEHNCNsUgphWsA2JdXJ9c+pQ@mail.gmail.com>
<2661153.1649186180@sss.pgh.pa.us>
On Tue, Apr 05, 2022 at 03:16:20PM -0400, Tom Lane wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> On Tue, Apr 5, 2022 at 10:32 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> My point is that we want that to happen in HEAD, but it's not okay
>>> for it to happen in a minor release of a stable branch.
>
>> I understand, but I am not sure that I agree. I think that if an
>> extension stops compiling against a back-branch, someone will notice
>> the next time they try to compile it and will fix it. Maybe that's not
>> amazing, but I don't think it's a huge deal either.
I agree with Tom's argument. The internals of this structure should
not have changed in a stable branch.
> Well, perhaps it's not the end of the world, but it's still a large
> PITA for the maintainer of such an extension. They can't "just fix it"
> because some percentage of their userbase will still need to compile
> against older minor releases. Nor have you provided any way to handle
> that requirement via conditional compilation.
For example, I recall that some external extensions make use of
sizeof(PGPROC) for their own business. Isn't 412ad7a going to be a
problem to change this structure's internals for already-compiled code
on stable branches?
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, markus.wanner@enterprisedb.com, pgsql-hackers@postgresql.org, horikyota.ntt@gmail.com
Subject: Re: API stability [was: pgsql: Fix possible recovery trouble if TRUNCATE overlaps a checkpoint.]
In-Reply-To: <Yk6Eg2YZ14TDTOPO@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox