From: Michael Paquier <michael@paquier.xyz>
To: Jeff Davis <jdavis@postgresql.org>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Add contrib/pg_walinspect.
Date: Tue, 26 Apr 2022 14:13:31 +0900
Message-ID: <Ymd/e5eeZMNAkrXo@paquier.xyz> (raw)
In-Reply-To: <E1ncj1z-000rJo-Kh@gemulon.postgresql.org>
References: <E1ncj1z-000rJo-Kh@gemulon.postgresql.org>
Hi Jeff,
On Fri, Apr 08, 2022 at 07:27:44AM +0000, Jeff Davis wrote:
> Add contrib/pg_walinspect.
>
> Provides similar functionality to pg_waldump, but from a SQL interface
> rather than a separate utility.
The tests of pg_walinspect look unstable:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=topminnow&dt=2022-04-25%2001%3A48%3A47
SELECT COUNT(*) >= 0 AS ok FROM
pg_get_wal_records_info_till_end_of_wal(:'wal_lsn1');
- ok
-----
- t
-(1 row)
-
+ERROR: could not read WAL at 0/1903E40
This points out at ReadNextXLogRecord(), though I would not blame this
test suite as you create a physical replication slot beforehand.
Could this be an issue related to the addition of the circular WAL
decoding buffer, aka 3f1ce97?
I am adding an open item about that.
Thanks,
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, jdavis@postgresql.org, thomas.munro@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Add contrib/pg_walinspect.
In-Reply-To: <Ymd/e5eeZMNAkrXo@paquier.xyz>
References: <E1ncj1z-000rJo-Kh@gemulon.postgresql.org> <Ymd/e5eeZMNAkrXo@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox