From: Michael Paquier <michael@paquier.xyz>
To: Noah Misch <noah@leadboat.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: last_archived_wal is not necessary the latest WAL file (was Re: pgsql: Add test case for an archive recovery corner case.)
Date: Mon, 27 Jun 2022 19:32:08 +0900
Message-ID: <YrmHKCOBA1tR9PFy@paquier.xyz> (raw)
In-Reply-To: <20220627070457.GA2176699@rfd.leadboat.com>
References: <E1nJXkI-0004VV-C3@gemulon.postgresql.org>
<2842251.1644849700@sss.pgh.pa.us>
<8f15e602-337e-fbb2-4b2e-e83a01ef9088@iki.fi>
<831b6ab9-45d6-7ab0-ea9c-6efd4383afb8@iki.fi>
<3186114.1644960507@sss.pgh.pa.us>
<40de25aa-2e20-08ad-e014-edb731594a74@iki.fi>
<20220627070457.GA2176699@rfd.leadboat.com>
On Mon, Jun 27, 2022 at 12:04:57AM -0700, Noah Misch wrote:
> For me, it reproduces consistently with a sleep just before the startup
> process exits:
Nice catch.
> One can adapt the test to the server behavior by having the test wait for the
> archiver to start, as attached. This is sufficient to make check-world pass
> with the above sleep in place. I think we should also modify the PostgresNode
> archive_command to log a message. That lack of logging was a obstacle
> upthread (as seen in commit 3279cef) and again here.
? qq{copy "%p" "$path\\\\%f"}
- : qq{cp "%p" "$path/%f"};
+ : qq{echo >&2 "ARCHIVE_COMMAND %p"; cp "%p" "$path/%f"};
This is a bit inelegant. Perhaps it would be better through a perl
wrapper like cp_history_files?
> An alternative would be to declare that the test is right and the server is
> wrong. The postmaster knows how to start the checkpointer if the checkpointer
> is not running when the postmaster needs a shutdown checkpoint. It could
> start the archiver around that same area:
>
> /* Start the checkpointer if not running */
> if (CheckpointerPID == 0)
> CheckpointerPID = StartCheckpointer();
> /* And tell it to shut down */
> if (CheckpointerPID != 0)
> {
> signal_child(CheckpointerPID, SIGUSR2);
> pmState = PM_SHUTDOWN;
> }
>
> Any opinions between the change-test and change-server approaches?
The startup sequence can be sometimes tricky. Though I don't have a
specific argument coming into mind, I would stick to a fix in the
test.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, noah@leadboat.com, hlinnaka@iki.fi, tgl@sss.pgh.pa.us, pgsql-hackers@postgresql.org
Subject: Re: last_archived_wal is not necessary the latest WAL file (was Re: pgsql: Add test case for an archive recovery corner case.)
In-Reply-To: <YrmHKCOBA1tR9PFy@paquier.xyz>
References: <E1nJXkI-0004VV-C3@gemulon.postgresql.org> <2842251.1644849700@sss.pgh.pa.us> <8f15e602-337e-fbb2-4b2e-e83a01ef9088@iki.fi> <831b6ab9-45d6-7ab0-ea9c-6efd4383afb8@iki.fi> <3186114.1644960507@sss.pgh.pa.us> <40de25aa-2e20-08ad-e014-edb731594a74@iki.fi> <20220627070457.GA2176699@rfd.leadboat.com> <YrmHKCOBA1tR9PFy@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox