From: Michael Paquier <michael@paquier.xyz>
To: Jeff Davis <jdavis@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove redundant pg_set_*_stats() variants.
Date: Wed, 26 Feb 2025 16:53:54 +0900
Message-ID: <Z77IkjmmfbFfNh3f@paquier.xyz> (raw)
In-Reply-To: <E1tn56k-0005t2-1d@gemulon.postgresql.org>
References: <E1tn56k-0005t2-1d@gemulon.postgresql.org>
Hi Jeff,
On Wed, Feb 26, 2025 at 12:17:03AM +0000, Jeff Davis wrote:
> Remove redundant pg_set_*_stats() variants.
>
> After commit f3dae2ae58, the primary purpose of separating the
> pg_set_*_stats() from the pg_restore_*_stats() variants was
> eliminated.
>
> Leave pg_restore_relation_stats() and pg_restore_attribute_stats(),
> which satisfy both purposes, and remove pg_set_relation_stats() and
> pg_set_attribute_stats().
>
> Reviewed-by: Corey Huinker <corey.huinker@gmail.com>
> Discussion: https://postgr.es/m/1457469.1740419458@sss.pgh.pa.us
I assume that you did not want to do that at the top of pg_proc.dat:
-#----------------------------------------------------------------------
+\#----------------------------------------------------------------------
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, jdavis@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove redundant pg_set_*_stats() variants.
In-Reply-To: <Z77IkjmmfbFfNh3f@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox