pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Remove redundant pg_set_*_stats() variants.
2+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2025-02-26 15df9d7b51 Remove stray diff introduced by a5cbdeb98a.
* pgsql: Remove redundant pg_set_*_stats() variants.
@ 2025-02-26 00:17 Jeff Davis <jdavis@postgresql.org>
2025-02-26 07:53 ` Re: pgsql: Remove redundant pg_set_*_stats() variants. Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Davis @ 2025-02-26 00:17 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Remove redundant pg_set_*_stats() variants.
After commit f3dae2ae58, the primary purpose of separating the
pg_set_*_stats() from the pg_restore_*_stats() variants was
eliminated.
Leave pg_restore_relation_stats() and pg_restore_attribute_stats(),
which satisfy both purposes, and remove pg_set_relation_stats() and
pg_set_attribute_stats().
Reviewed-by: Corey Huinker <corey.huinker@gmail.com>
Discussion: https://postgr.es/m/1457469.1740419458@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/a5cbdeb98af9a8d4f683fbffa69cd74be1f4a084
Modified Files
--------------
doc/src/sgml/func.sgml | 254 +++---
src/backend/catalog/system_functions.sql | 32 -
src/backend/statistics/attribute_stats.c | 98 +-
src/backend/statistics/relation_stats.c | 24 +-
src/backend/statistics/stat_utils.c | 30 +-
src/include/catalog/catversion.h | 2 +-
src/include/catalog/pg_proc.dat | 32 +-
src/include/statistics/stat_utils.h | 8 +-
src/test/regress/expected/stats_import.out | 1339 ++++++++--------------------
src/test/regress/sql/stats_import.sql | 1075 +++++++---------------
10 files changed, 872 insertions(+), 2022 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: pgsql: Remove redundant pg_set_*_stats() variants.
2025-02-26 00:17 pgsql: Remove redundant pg_set_*_stats() variants. Jeff Davis <jdavis@postgresql.org>
@ 2025-02-26 07:53 ` Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 2+ messages in thread
From: Michael Paquier @ 2025-02-26 07:53 UTC (permalink / raw)
To: Jeff Davis <jdavis@postgresql.org>; +Cc: pgsql-committers@lists.postgresql.org
Hi Jeff,
On Wed, Feb 26, 2025 at 12:17:03AM +0000, Jeff Davis wrote:
> Remove redundant pg_set_*_stats() variants.
>
> After commit f3dae2ae58, the primary purpose of separating the
> pg_set_*_stats() from the pg_restore_*_stats() variants was
> eliminated.
>
> Leave pg_restore_relation_stats() and pg_restore_attribute_stats(),
> which satisfy both purposes, and remove pg_set_relation_stats() and
> pg_set_attribute_stats().
>
> Reviewed-by: Corey Huinker <corey.huinker@gmail.com>
> Discussion: https://postgr.es/m/1457469.1740419458@sss.pgh.pa.us
I assume that you did not want to do that at the top of pg_proc.dat:
-#----------------------------------------------------------------------
+\#----------------------------------------------------------------------
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2025-02-26 07:53 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-02-26 00:17 pgsql: Remove redundant pg_set_*_stats() variants. Jeff Davis <jdavis@postgresql.org>
2025-02-26 07:53 ` Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox