pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Don't initialize page in {vm,fsm}_extend(), not needed
Date: Thu, 6 Apr 2023 08:34:02 +0900
Message-ID: <ZC4Fagcr7zft5LZ9@paquier.xyz> (raw)
In-Reply-To: <2194723.1680736788@sss.pgh.pa.us>
References: <E1pk5tJ-001W2q-Bq@gemulon.postgresql.org>
	<2194723.1680736788@sss.pgh.pa.us>

On Wed, Apr 05, 2023 at 07:19:48PM -0400, Tom Lane wrote:
> freespace.c: In function \342\200\230fsm_extend\342\200\231:
> freespace.c:611:2: warning: missing braces around initializer [-Wmissing-braces]
>   PGAlignedBlock pg = {0};
>   ^
> freespace.c:611:2: warning: (near initialization for \342\200\230pg.data\342\200\231) [-Wmissing-braces]
> 
> This is from buri, similar from curculio, dragonet, idiacanthus,
> xenodermus, etc

That's the same as d937904, it seems, requiring a {{0}}.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (5+ messages)  latest in thread

Message-ID: <ZC4Fagcr7zft5LZ9@paquier.xyz>
Permalink:  ../ZC4Fagcr7zft5LZ9@paquier.xyz/
Also on:    postgresql.org/message-id/ZC4Fagcr7zft5LZ9@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, andres@anarazel.de, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Don't initialize page in {vm,fsm}_extend(), not needed
  In-Reply-To: <ZC4Fagcr7zft5LZ9@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox