pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Tatsuo Ishii <ishii@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Allow pgbench to exit immediately when any client is aborted.
Date: Wed, 30 Aug 2023 13:16:20 +0900
Message-ID: <ZO7ClGElQkqnJ6xK@paquier.xyz> (raw)
In-Reply-To: <E1qb9dy-001bO7-NI@gemulon.postgresql.org>
References: <E1qb9dy-001bO7-NI@gemulon.postgresql.org>

Hi Ishii-san,

On Wed, Aug 30, 2023 at 01:05:15AM +0000, Tatsuo Ishii wrote:
> Allow pgbench to exit immediately when any client is aborted.
> 
> Previously when client was aborted due to some error during
> benchmarking, other clients continued their run until certain number
> of transactions specified -t was reached or the time specified by -T
> was expired. At the end, the results are printed with caution: "Run
> was aborted; the above results are incomplete" shows.
> 
> New option "--exit-on-abort" allows pgbench to exit immediately in
> this case so that users could quickly fix the cause of the failure and
> try again another round of benchmarking.

Buildfarm member koel is saying that this commit was not properly
indented:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=koel&dt=2023-08-30%2002%3A19%3A02

Could you address this with a run of pgindent?

After the reindent is itself committed, you should also add the commit
that did the indentation to .git-blame-ignore-revs.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (3+ messages)  latest in thread

Message-ID: <ZO7ClGElQkqnJ6xK@paquier.xyz>
Permalink:  ../ZO7ClGElQkqnJ6xK@paquier.xyz/
Also on:    postgresql.org/message-id/ZO7ClGElQkqnJ6xK@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, ishii@postgresql.org
  Subject: Re: pgsql: Allow pgbench to exit immediately when any client is aborted.
  In-Reply-To: <ZO7ClGElQkqnJ6xK@paquier.xyz>
  References: <E1qb9dy-001bO7-NI@gemulon.postgresql.org> <ZO7ClGElQkqnJ6xK@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox