From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <tmunro@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix potential stack overflow in incremental backup.
Date: Thu, 11 Apr 2024 11:27:54 +0900
Message-ID: <ZhdKqj5DwoOzirFv@paquier.xyz> (raw)
In-Reply-To: <E1rujcx-001X28-QA@gemulon.postgresql.org>
References: <E1rujcx-001X28-QA@gemulon.postgresql.org>
Hi Thomas,
On Thu, Apr 11, 2024 at 01:53:24AM +0000, Thomas Munro wrote:
> Fix potential stack overflow in incremental backup.
>
> The user can set RELSEG_SIZE to a high number at compile time, so we
> can't use it to control the size of an array on the stack: it could be
> many gigabytes in size. On closer inspection, we don't really need that
> intermediate array anyway. Let's just write directly into the output
> array, and then perform the absolute->relative adjustment in place.
> This fixes new code from commit dc212340058.
+ * file just as if this were not an incremental backup. The contents of the
+ * relative_block_numbers array is unspecified in this case.
Perhaps you mean s/is/are/ here? The contents are what's not
specified.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, tmunro@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix potential stack overflow in incremental backup.
In-Reply-To: <ZhdKqj5DwoOzirFv@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox