From: Peter Eisentraut <peter@eisentraut.org>
To: Tomas Vondra <tomas.vondra@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Improve BRIN minmax-multi opclass test coverage
Date: Tue, 22 Aug 2023 08:43:08 +0200
Message-ID: <a35eaf0f-b19c-7797-e296-7b7e2adc473e@eisentraut.org> (raw)
In-Reply-To: <E1qFsXm-001Uqd-Tv@gemulon.postgresql.org>
References: <E1qFsXm-001Uqd-Tv@gemulon.postgresql.org>
These new tests introduced a few new calls of the md5() function. This
should be avoided (see commit 208bf364a9). You can replace these easily
with the fipshash() function instead, but I think you then also need to
change some of the constants in the tests. Could you look at this again?
On 02.07.23 10:34, Tomas Vondra wrote:
> Improve BRIN minmax-multi opclass test coverage
>
> Per the code coverage report, the existing regression tests did not
> exercice some a couple important BRIN minmax-multi code paths.
>
> - The tests focused on testing planning with a range of scan key
> strategies, but not the execution. Fixed by adding queries that
> actually test query execution for both equality and inequality.
>
> - All tests created indexes after inserting data, but this only
> exercises the CREATE INDEX strategy that sees all values at once, not
> incremental summary updates. The new tests flip the order and create
> the index before adding data.
>
> - The assert check(s) validating correctness of expanded ranges were
> present only in the "union" code path, which is not covered by
> regression tests at all (as it requires concurrency etc.). Fixed by
> adding the asserts to a couple more places.
>
> Reviewed-by: Heikki Linnakangas
> Discussion: https://postgr.es/m/57020b2e-d9c9-9bc7-4892-b36d9bb07563%40enterprisedb.com
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/0457109344b46f481f9bf09b85674695ba57c8e4
>
> Modified Files
> --------------
> src/backend/access/brin/brin_minmax_multi.c | 9 +
> src/test/regress/expected/brin_multi.out | 357 ++++++++++++++++++++++++++++
> src/test/regress/sql/brin_multi.sql | 165 +++++++++++++
> 3 files changed, 531 insertions(+)
>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, tomas.vondra@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Improve BRIN minmax-multi opclass test coverage
In-Reply-To: <a35eaf0f-b19c-7797-e296-7b7e2adc473e@eisentraut.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox