public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andres Freund <[email protected]>
To: Tom Lane <[email protected]>
Cc: [email protected]
Subject: Re: pgsql: aio: Add core asynchronous I/O infrastructure
Date: Wed, 19 Mar 2025 10:29:19 -0400
Message-ID: <a54pqocps46awa4b2tlwmrjz5k3b3jastg5py6thtnqtlr2ksy@notafhjwiuec> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<ecqk4e772iqtwuwfu56yr3cv5wnzug6fpqvmwjcwlduqlom5xr@2fzz3cdycdyb>
	<[email protected]>

Hi,

On 2025-03-18 11:26:15 -0400, Tom Lane wrote:
> Andres Freund <[email protected]> writes:
> > I wonder if we should instead either ask those buildfarm animals to be
> > disabled or have the warning manually disabled. I don't think it's a good
> > investment on our part to work towards warning cleanliness on clang 4 and 5,
> > on distros from 2017 and and 2018 respectively.
> 
> Well, if we don't want to fix it I can just adjust my warning-scraping
> script to ignore these.  Let's wait a bit and see if any newer
> compilers warn similarly before deciding.

FWIW, adding a few casts does silence the warnings, at least on clang-3.9,
which I had around.

But there also are other warnings on that compiler, mainly stuff like:

../../home/andres/src/postgresql/src/interfaces/libpq/fe-auth-oauth-curl.c:1437:28: warning: suggest braces around initialization of subobject [-Wmissing-braces]
        struct itimerspec spec = {0};


I lean towards not fixing this stuff, but if you would like me to, I can.

Greetings,

Andres Freund

view thread (8+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: pgsql: aio: Add core asynchronous I/O infrastructure
  In-Reply-To: <a54pqocps46awa4b2tlwmrjz5k3b3jastg5py6thtnqtlr2ksy@notafhjwiuec>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox