pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Sami Imseih <samimseih@gmail.com>
Cc: Mircea Cadariu <cadariu.mircea@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Frédéric Yhuel <frederic.yhuel@dalibo.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Drop unnamed portal immediately after execution to completion
Date: Fri, 14 Nov 2025 15:04:25 +0900
Message-ID: <aRbGaQTisuKMREuS@paquier.xyz> (raw)
In-Reply-To: <CAA5RZ0uFhj3bGbwSFWX1_hRhdHvp3JO1zAuSvp=XrfOoZ2GCcw@mail.gmail.com>
References: <E1vGWIt-0056al-2N@gemulon.postgresql.org>
	<CA+TgmoYFJyJNQw3RT7veO3M2BWRE9Aw4hprC5rOcawHZti-f8g@mail.gmail.com>
	<1982325.1762810082@sss.pgh.pa.us>
	<aRJ1zn0z-Bn0qc2H@paquier.xyz>
	<CA+TgmoYR2OP8C+MHC8VCA80-r=Q09aF-_=juvBLvUKS09d__Mw@mail.gmail.com>
	<00d71a54-2118-4b18-87e8-33f4a99dc624@gmail.com>
	<aRV6D3vxMQTQ7CxG@paquier.xyz>
	<e0ab1ea2-7084-44c5-b6aa-f01db7be7792@gmail.com>
	<CAA5RZ0uFhj3bGbwSFWX1_hRhdHvp3JO1zAuSvp=XrfOoZ2GCcw@mail.gmail.com>

On Thu, Nov 13, 2025 at 04:02:24PM -0600, Sami Imseih wrote:
> I am not sure I like this idea as-is, because besides that fact
> that it's still a wire level change, it's not safe at all to
> re-enter exec_execute_message after you just cleaned the
> portal but did not drop it.

This will come at the cost of tracking a new state in the backend
where the portal would still live with the executor state gone, I
don't like much my own plan D and the road where this leads at the
end.

> That is probably the best idea now.

I have just done a revert of 1fd981f05369 now, let's continue the
discussions.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (14+ messages)  latest in thread

Message-ID: <aRbGaQTisuKMREuS@paquier.xyz>
Permalink:  ../aRbGaQTisuKMREuS@paquier.xyz/
Also on:    postgresql.org/message-id/aRbGaQTisuKMREuS@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, samimseih@gmail.com, cadariu.mircea@gmail.com, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, frederic.yhuel@dalibo.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Drop unnamed portal immediately after execution to completion
  In-Reply-To: <aRbGaQTisuKMREuS@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox