pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Teach DSM registry to ERROR if attaching to an uninitialized ent
Date: Wed, 26 Nov 2025 15:21:13 -0600
Message-ID: <aSdvSZz9DMPmuGTk@nathan> (raw)
In-Reply-To: <CA+TgmoaSpDa8dqWBwjRAittp+XTKN698Tpg3CEMpi=08sKc4Sw@mail.gmail.com>
References: <aSSr6j3JzeLcqOWo@nathan>
	<CA+TgmoYq7U0hHgOEOqQgf=6cFXz_7Ab8QTRMFqFpLNfav0G4Ug@mail.gmail.com>
	<aSTNXyXnr9HYsLo6@nathan>
	<CA+Tgmob6knHwEbQv11n_Yy0GyFzPgjhC33LroWso0prt7hCksg@mail.gmail.com>
	<aSXQOAZuA4rX9ooU@nathan>
	<CA+TgmobGYDczmVa-UDGPgcyN=63PJzzyQ9ZCofou4VYH8TVLSQ@mail.gmail.com>
	<aSXrPqV3Bcm2HLV4@nathan>
	<CA+Tgmob=uQymuQuWfsnk3ixe6BEURK1Fjm-0WUy7E5YVsWoNHA@mail.gmail.com>
	<aSYckI8dlAx23HBe@nathan>
	<CA+TgmoaSpDa8dqWBwjRAittp+XTKN698Tpg3CEMpi=08sKc4Sw@mail.gmail.com>

On Tue, Nov 25, 2025 at 07:13:03PM -0500, Robert Haas wrote:
> On Tue, Nov 25, 2025 at 4:16 PM Nathan Bossart <nathandbossart@gmail.com> wrote:
>> My tests seem happy, so I will plan on committing these patches tomorrow.
>> The only difference in v4 is that pg_get_dsm_registry_allocations() will no
>> longer show partially-initialized entries.  I thought that was the best
>> option in this case because such entries shouldn't have any allocated
>> memory, and retrying GetNamed*() would set *found to false.
> 
> Without actually opening the new patch files, that seems OK to me. I
> think the important thing about such a view is that it shouldn't make
> any state changes; it should just show how things are. In my ideal
> world, it would probably show partially-initialized entires in some
> distinguishable way, like with a null size. But leaving them out is
> also defensible. The thing that I think really matters for failure
> cases is the ability to retry whatever's gone wrong, either to get it
> fixed or to see the error, and the other changes already accomplish
> that goal, so I'm happy.

Committed, thanks for reviewing.

-- 
nathan





view thread (21+ messages)

Message-ID: <aSdvSZz9DMPmuGTk@nathan>
Permalink:  ../aSdvSZz9DMPmuGTk@nathan/
Also on:    postgresql.org/message-id/aSdvSZz9DMPmuGTk@nathan

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: nathandbossart@gmail.com, robertmhaas@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Teach DSM registry to ERROR if attaching to an uninitialized ent
  In-Reply-To: <aSdvSZz9DMPmuGTk@nathan>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox