From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add data type oid8, 64-bit unsigned identifier
Date: Wed, 7 Jan 2026 12:12:38 +0900
Message-ID: <aV3PJvIpF8fmhfIL@paquier.xyz> (raw)
In-Reply-To: <1656709.1767754981@sss.pgh.pa.us>
References: <E1vdJS7-0050ga-1o@gemulon.postgresql.org>
<1656709.1767754981@sss.pgh.pa.us>
On Tue, Jan 06, 2026 at 10:03:01PM -0500, Tom Lane wrote:
> sifaka doesn't like this, evidently because it uses
> -DSTRESS_SORT_INT_MIN.
Yes, I have noticed that. I was just going to push a workaround that
uses '>' and '<' comparators instead of the direct outputs..
> Personally I'd just drop those tests of btoid8cmp --- what are they
> going to catch that's not caught by other tests?
btoid8cmp() is not tested directly by other tests, which is why, like
for the xid8 case, I have just added direct calls because that's
cheaper.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add data type oid8, 64-bit unsigned identifier
In-Reply-To: <aV3PJvIpF8fmhfIL@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox