pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.
Date: Fri, 8 Oct 2021 16:28:45 -0400
Message-ID: <aa23a59b-f40d-5f52-ac84-5d7830573b9b@dunslane.net> (raw)
In-Reply-To: <4941f5a5-2d50-1a0e-6701-14c5fefe92d6@dunslane.net>
References: <E1mWR73-0000qh-Eq@gemulon.postgresql.org>
	<4941f5a5-2d50-1a0e-6701-14c5fefe92d6@dunslane.net>


On 10/8/21 11:41 AM, Andrew Dunstan wrote:
> On 10/1/21 6:34 PM, Andres Freund wrote:
>> Reference test binary using TESTDIR in 001_libpq_pipeline.pl.
>>
>> The previous approach didn't really work on windows, due to the PATH separator
>> being ';' not ':'. Instead of making the PATH change more complicated,
>> reference the binary using the TESTDIR environment.
>>
>> Reported-By: Andres Freund <andres@anarazel.de>
>> Suggested-By: Andrew Dunstan <andrew@dunslane.net>
>> Discussion: https://postgr.es/m/20210930214040.odkdd42vknvzifm6@alap3.anarazel.de
>> Backpatch: 14-, where the test was introduced.
>>
> I don't think any of us were thinking very clearly about this. Of
> course, MSVC doesn't build executables in $TESTDIR. If we want to pick
> up the executable from where it's built we'll need a little help from
> vcregress.pl. I haven't tested it but What I have in mind is something
> like the attached.
>
>

Confirmed that this makes the test pass.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com






view thread (15+ messages)  latest in thread

Message-ID: <aa23a59b-f40d-5f52-ac84-5d7830573b9b@dunslane.net>
Permalink:  ../aa23a59b-f40d-5f52-ac84-5d7830573b9b@dunslane.net/
Also on:    postgresql.org/message-id/aa23a59b-f40d-5f52-ac84-5d7830573b9b@dunslane.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net, andres@anarazel.de
  Subject: Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.
  In-Reply-To: <aa23a59b-f40d-5f52-ac84-5d7830573b9b@dunslane.net>
  References: <E1mWR73-0000qh-Eq@gemulon.postgresql.org> <4941f5a5-2d50-1a0e-6701-14c5fefe92d6@dunslane.net> <aa23a59b-f40d-5f52-ac84-5d7830573b9b@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox