From: Peter Eisentraut <peter@eisentraut.org>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
To: Peter Smith <smithpb2250@gmail.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: tests: Add a test C++ extension module
Date: Thu, 22 Jan 2026 14:47:28 +0100
Message-ID: <abb76852-0299-4b11-b487-862f1567f712@eisentraut.org> (raw)
In-Reply-To: <82808f49-ed07-42a3-a736-8b678988765f@eisentraut.org>
References: <E1viDt1-001d7E-2I@gemulon.postgresql.org>
<CAHut+Psr0yk7nbtX63Mc5+C_dND1LV-SxO7uw=mWbvHxhKwUrQ@mail.gmail.com>
<DFU506DCCMQ6.SWR87ADZHSCT@jeltef.nl>
<82808f49-ed07-42a3-a736-8b678988765f@eisentraut.org>
On 21.01.26 10:44, Peter Eisentraut wrote:
> On 21.01.26 09:50, Jelte Fennema-Nio wrote:
>> On Wed Jan 21, 2026 at 4:27 AM CET, Peter Smith wrote:
>>> 'make check-world' is suddenly failing for me, apparently caused by
>>> this new test.
>>>
>>> FYI - I am building in a 'Linux CentOS7-x64 ' environment, which I
>>> know has reached end-of-life, but even so, everything was fine before
>>> this test appeared.
>>
>>
>> I'm still not clear on what our policy is on supporting such EOL
>> distros. But this patch seems sensible regardless and it fixes
>> compilation for me when running on a centos 7 docker image.
>
> Yes, I was just in the process of writing that same patch. I'll see if
> there are any differences and then move ahead with this.
This has been committed, and at least one buildfarm member has confirmed
so far. The other ones are just very slow.
During testing, I noticed that my hack from an earlier patch to compute
have_cxx in configure didn't work well when you specify CXX from the
environment. So I implemented a different solution for that. Also, my
reading and testing showed that MSVC doesn't have a /std:c++11 option,
the oldest one is /std:c++14, so I went with that.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, postgres@jeltef.nl, smithpb2250@gmail.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: tests: Add a test C++ extension module
In-Reply-To: <abb76852-0299-4b11-b487-862f1567f712@eisentraut.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox