pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: psql: Add test for query canceling
Date: Fri, 20 Aug 2021 17:40:05 +0200 (CEST)
Message-ID: <alpine.DEB.2.22.394.2108201736060.498998@pseudo> (raw)
In-Reply-To: <DD279DFC-DD59-458E-B469-75DC941765A4@yesql.se>
References: <E1mH14Q-0002gh-HS@gemulon.postgresql.org>
	<DD279DFC-DD59-458E-B469-75DC941765A4@yesql.se>


>> psql: Add test for query canceling
>
> Seems sidewinder didn’t quite like this:

> Nothing obvious sticks out, could it be timing related?

Hmmm. Possibly, as the test is time dependent, hence the "SKIP:" section, 
which should mean that the test should be ignore when it fails. It seems 
that this part did not work. Maybe it should not state that it is 
expecting 2 results?

   use Test::More tests => 2;

Replace by:

   use Test::More;

Or something is amiss with the "SKIP" section trick?

-- 
Fabien.

view thread (20+ messages)  latest in thread

Message-ID: <alpine.DEB.2.22.394.2108201736060.498998@pseudo>
Permalink:  ../alpine.DEB.2.22.394.2108201736060.498998@pseudo/
Also on:    postgresql.org/message-id/alpine.DEB.2.22.394.2108201736060.498998@pseudo

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: coelho@cri.ensmp.fr, daniel@yesql.se, peter.eisentraut@enterprisedb.com
  Subject: Re: pgsql: psql: Add test for query canceling
  In-Reply-To: <alpine.DEB.2.22.394.2108201736060.498998@pseudo>
  References: <E1mH14Q-0002gh-HS@gemulon.postgresql.org> <DD279DFC-DD59-458E-B469-75DC941765A4@yesql.se> <alpine.DEB.2.22.394.2108201736060.498998@pseudo>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox