agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
pgsql: Fix compilation with OpenSSL 4
8+ messages / 3 participants
[nested] [flat]

* pgsql: Fix compilation with OpenSSL 4
@ 2026-05-29 19:53  Daniel Gustafsson <dgustafsson@postgresql.org>
  0 siblings, 0 replies; 8+ messages in thread

From: Daniel Gustafsson @ 2026-05-29 19:53 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix compilation with OpenSSL 4

OpenSSL 4.0.0 changed some parameters and returnvalues to const, so
we need to update our declarations and subsequently cast away const-
ness from a few callsites to make libpq build without warnings. This
is tested with OpenSSL 1.1.1 through 4.0.0 as well as with LibreSSL.
No functional change is introduced, this commit only allows postgres
to be compiled against OpenSSL 4.0.0 without warnings.

There is also an errormessage change in OpenSSL 4.0.0 which needed
to be covered by our testharness.

This will be backpatched to all supported branches since they are
all equally likely to be built against OpenSSL 4.0.0 as it becomes
available in distributions.  Backpatching will be done once it has
been in master for a few days without issues.

Author: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/066B07BB-85FA-487C-BE8C-40F791CFC3C4@yesql.se
Backpatch-through: 14

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/89d243d52189ad426538012e0db9aad441240e68

Modified Files
--------------
contrib/sslinfo/sslinfo.c                | 20 ++++++++++----------
src/backend/libpq/be-secure-openssl.c    | 14 +++++++-------
src/interfaces/libpq/fe-secure-openssl.c |  9 +++++----
src/test/ssl/t/001_ssltests.pl           |  6 +++---
4 files changed, 25 insertions(+), 24 deletions(-)



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* pgsql: Fix compilation with OpenSSL 4
@ 2026-06-12 12:12  Daniel Gustafsson <dgustafsson@postgresql.org>
  0 siblings, 0 replies; 8+ messages in thread

From: Daniel Gustafsson @ 2026-06-12 12:12 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix compilation with OpenSSL 4

OpenSSL 4.0.0 changed some parameters and returnvalues to const, so
we need to update our declarations and subsequently cast away const-
ness from a few callsites to make libpq build without warnings. This
is tested with OpenSSL 1.1.1 through 4.0.0 as well as with LibreSSL.
No functional change is introduced, this commit only allows postgres
to be compiled against OpenSSL 4.0.0 without warnings.

There is also an errormessage change in OpenSSL 4.0.0 which needed
to be covered by our testharness.

This will be backpatched to all supported branches since they are
all equally likely to be built against OpenSSL 4.0.0 as it becomes
available in distributions.  Backpatching will be done once it has
been in master for a few days without issues.

Author: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/066B07BB-85FA-487C-BE8C-40F791CFC3C4@yesql.se
Backpatch-through: 14

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/27cf3b5aff4fdb53d00f44760ecdce06ddb02925

Modified Files
--------------
contrib/sslinfo/sslinfo.c                | 20 ++++++++++----------
src/backend/libpq/be-secure-openssl.c    | 14 +++++++-------
src/interfaces/libpq/fe-secure-openssl.c |  9 +++++----
src/test/ssl/t/001_ssltests.pl           |  6 +++---
4 files changed, 25 insertions(+), 24 deletions(-)



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* pgsql: Fix compilation with OpenSSL 4
@ 2026-06-12 12:13  Daniel Gustafsson <dgustafsson@postgresql.org>
  0 siblings, 1 reply; 8+ messages in thread

From: Daniel Gustafsson @ 2026-06-12 12:13 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix compilation with OpenSSL 4

OpenSSL 4.0.0 changed some parameters and returnvalues to const, so
we need to update our declarations and subsequently cast away const-
ness from a few callsites to make libpq build without warnings. This
is tested with OpenSSL 1.1.1 through 4.0.0 as well as with LibreSSL.
No functional change is introduced, this commit only allows postgres
to be compiled against OpenSSL 4.0.0 without warnings.

There is also an errormessage change in OpenSSL 4.0.0 which needed
to be covered by our testharness.

This will be backpatched to all supported branches since they are
all equally likely to be built against OpenSSL 4.0.0 as it becomes
available in distributions.  Backpatching will be done once it has
been in master for a few days without issues.

Author: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/066B07BB-85FA-487C-BE8C-40F791CFC3C4@yesql.se
Backpatch-through: 14

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/8bcabfccea32b9ed169312163b116a2b8f320f5c

Modified Files
--------------
contrib/sslinfo/sslinfo.c                | 26 +++++++++++++-------------
src/backend/libpq/be-secure-openssl.c    | 26 +++++++++++++-------------
src/interfaces/libpq/fe-secure-openssl.c | 13 +++++++------
src/test/ssl/t/001_ssltests.pl           |  4 ++--
4 files changed, 35 insertions(+), 34 deletions(-)



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* pgsql: Fix compilation with OpenSSL 4
@ 2026-06-12 12:15  Daniel Gustafsson <dgustafsson@postgresql.org>
  0 siblings, 0 replies; 8+ messages in thread

From: Daniel Gustafsson @ 2026-06-12 12:15 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix compilation with OpenSSL 4

OpenSSL 4.0.0 changed some parameters and returnvalues to const, so
we need to update our declarations and subsequently cast away const-
ness from a few callsites to make libpq build without warnings. This
is tested with OpenSSL 1.1.1 through 4.0.0 as well as with LibreSSL.
No functional change is introduced, this commit only allows postgres
to be compiled against OpenSSL 4.0.0 without warnings.

There is also an errormessage change in OpenSSL 4.0.0 which needed
to be covered by our testharness.

This will be backpatched to all supported branches since they are
all equally likely to be built against OpenSSL 4.0.0 as it becomes
available in distributions.  Backpatching will be done once it has
been in master for a few days without issues.

Author: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/066B07BB-85FA-487C-BE8C-40F791CFC3C4@yesql.se
Backpatch-through: 14

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/fb8befa7b57038ebdaaf6f15626ca62bdaaf1519

Modified Files
--------------
contrib/sslinfo/sslinfo.c                | 24 ++++++++++++------------
src/backend/libpq/be-secure-openssl.c    | 26 +++++++++++++-------------
src/interfaces/libpq/fe-secure-openssl.c | 13 +++++++------
src/test/ssl/t/001_ssltests.pl           |  4 ++--
4 files changed, 34 insertions(+), 33 deletions(-)



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* pgsql: Fix compilation with OpenSSL 4
@ 2026-06-12 12:15  Daniel Gustafsson <dgustafsson@postgresql.org>
  0 siblings, 0 replies; 8+ messages in thread

From: Daniel Gustafsson @ 2026-06-12 12:15 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix compilation with OpenSSL 4

OpenSSL 4.0.0 changed some parameters and returnvalues to const, so
we need to update our declarations and subsequently cast away const-
ness from a few callsites to make libpq build without warnings. This
is tested with OpenSSL 1.1.1 through 4.0.0 as well as with LibreSSL.
No functional change is introduced, this commit only allows postgres
to be compiled against OpenSSL 4.0.0 without warnings.

There is also an errormessage change in OpenSSL 4.0.0 which needed
to be covered by our testharness.

This will be backpatched to all supported branches since they are
all equally likely to be built against OpenSSL 4.0.0 as it becomes
available in distributions.  Backpatching will be done once it has
been in master for a few days without issues.

Author: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/066B07BB-85FA-487C-BE8C-40F791CFC3C4@yesql.se
Backpatch-through: 14

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c7f70fa1b58d0fc22a49779e1b1f30f8b7065d79

Modified Files
--------------
contrib/sslinfo/sslinfo.c                | 24 ++++++++++++------------
src/backend/libpq/be-secure-openssl.c    | 26 +++++++++++++-------------
src/interfaces/libpq/fe-secure-openssl.c |  9 +++++----
src/test/ssl/t/001_ssltests.pl           |  4 ++--
4 files changed, 32 insertions(+), 31 deletions(-)



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* pgsql: Fix compilation with OpenSSL 4
@ 2026-06-12 12:16  Daniel Gustafsson <dgustafsson@postgresql.org>
  0 siblings, 0 replies; 8+ messages in thread

From: Daniel Gustafsson @ 2026-06-12 12:16 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix compilation with OpenSSL 4

OpenSSL 4.0.0 changed some parameters and returnvalues to const, so
we need to update our declarations and subsequently cast away const-
ness from a few callsites to make libpq build without warnings. This
is tested with OpenSSL 1.1.1 through 4.0.0 as well as with LibreSSL.
No functional change is introduced, this commit only allows postgres
to be compiled against OpenSSL 4.0.0 without warnings.

There is also an errormessage change in OpenSSL 4.0.0 which needed
to be covered by our testharness.

This will be backpatched to all supported branches since they are
all equally likely to be built against OpenSSL 4.0.0 as it becomes
available in distributions.  Backpatching will be done once it has
been in master for a few days without issues.

Author: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/066B07BB-85FA-487C-BE8C-40F791CFC3C4@yesql.se
Backpatch-through: 14

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/086652c02f49ca04c3123faf14b2f5cabdf31f7d

Modified Files
--------------
contrib/sslinfo/sslinfo.c                | 24 ++++++++++++------------
src/backend/libpq/be-secure-openssl.c    | 26 +++++++++++++-------------
src/interfaces/libpq/fe-secure-openssl.c | 13 +++++++------
src/test/ssl/t/001_ssltests.pl           |  4 ++--
4 files changed, 34 insertions(+), 33 deletions(-)



^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* Re: pgsql: Fix compilation with OpenSSL 4
@ 2026-09-03 08:42  Christoph Berg <cb@df7cb.de>
  parent: Daniel Gustafsson <dgustafsson@postgresql.org>
  0 siblings, 1 reply; 8+ messages in thread

From: Christoph Berg @ 2026-09-03 08:42 UTC (permalink / raw)
  To: Daniel Gustafsson <dgustafsson@postgresql.org>; +Cc: pgsql-hackers@lists.postgresql.org

Re: Daniel Gustafsson
> There is also an errormessage change in OpenSSL 4.0.0 which needed
> to be covered by our testharness.

The backpatches of the message test are incomplete for 16 and 17:

git show origin/REL_16_STABLE:src/test/ssl/t/001_ssltests.pl | grep 'alert certificate revoked'
	expected_stderr => qr!SSL error: (ssl[a-z0-9/]*|tls) alert certificate revoked!,
	expected_stderr => qr!SSL error: (ssl[a-z0-9/]*|tls) alert certificate revoked!,
	expected_stderr => qr|SSL error: ssl[a-z0-9/]* alert certificate revoked|,

git show origin/REL_17_STABLE:src/test/ssl/t/001_ssltests.pl | grep 'alert certificate revoked'
	expected_stderr => qr!SSL error: (ssl[a-z0-9/]*|tls) alert certificate revoked!,
	expected_stderr => qr!SSL error: (ssl[a-z0-9/]*|tls) alert certificate revoked!,
	expected_stderr => qr|SSL error: ssl[a-z0-9/]* alert certificate revoked|,

18/15/14 are ok:

git show origin/REL_18_STABLE:src/test/ssl/t/001_ssltests.pl | grep 'alert certificate revoked'
	expected_stderr => qr!SSL error: (ssl[a-z0-9/]*|tls) alert certificate revoked!,
	expected_stderr => qr!SSL error: (ssl[a-z0-9/]*|tls) alert certificate revoked!,
	expected_stderr => qr!SSL error: (ssl[a-z0-9/]*|tls) alert certificate revoked!,

Noticed while bootstrapping the new Ubuntu stonking 26.10 for apt.pg.o.

Christoph






^ permalink  raw  reply  [nested|flat] 8+ messages in thread

* Re: pgsql: Fix compilation with OpenSSL 4
@ 2026-09-04 11:47  Daniel Gustafsson <daniel@yesql.se>
  parent: Christoph Berg <cb@df7cb.de>
  0 siblings, 0 replies; 8+ messages in thread

From: Daniel Gustafsson @ 2026-09-04 11:47 UTC (permalink / raw)
  To: Christoph Berg <cb@df7cb.de>; +Cc: pgsql-hackers@lists.postgresql.org

> On 3 Sep 2026, at 10:42, Christoph Berg <cb@df7cb.de> wrote:
> 
> Re: Daniel Gustafsson
>> There is also an errormessage change in OpenSSL 4.0.0 which needed
>> to be covered by our testharness.
> 
> The backpatches of the message test are incomplete for 16 and 17:

Fixed, thanks for the report!

--
Daniel Gustafsson







^ permalink  raw  reply  [nested|flat] 8+ messages in thread


end of thread, other threads:[~2026-09-04 11:47 UTC | newest]

Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-05-29 19:53 pgsql: Fix compilation with OpenSSL 4 Daniel Gustafsson <dgustafsson@postgresql.org>
2026-06-12 12:12 pgsql: Fix compilation with OpenSSL 4 Daniel Gustafsson <dgustafsson@postgresql.org>
2026-06-12 12:13 pgsql: Fix compilation with OpenSSL 4 Daniel Gustafsson <dgustafsson@postgresql.org>
2026-09-03 08:42 ` Christoph Berg <cb@df7cb.de>
2026-09-04 11:47   ` Daniel Gustafsson <daniel@yesql.se>
2026-06-12 12:15 pgsql: Fix compilation with OpenSSL 4 Daniel Gustafsson <dgustafsson@postgresql.org>
2026-06-12 12:15 pgsql: Fix compilation with OpenSSL 4 Daniel Gustafsson <dgustafsson@postgresql.org>
2026-06-12 12:16 pgsql: Fix compilation with OpenSSL 4 Daniel Gustafsson <dgustafsson@postgresql.org>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox