From: Peter Eisentraut <peter@eisentraut.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers@lists.postgresql.org, Jacob Champion <jacob.champion@enterprisedb.com>
Subject: Re: pgsql: Fix overread in JSON parsing errors for incomplete byte sequence
Date: Wed, 15 May 2024 08:15:37 +0200
Message-ID: <bc57073e-27a3-4a4a-9d93-ef734d473a74@eisentraut.org> (raw)
In-Reply-To: <ZkP7ARo6lo90su3K@paquier.xyz>
References: <202405101223.66lahv2qiwe7@alvherre.pgsql>
<6dae7e56-5233-4183-bd12-c14cf3c9312e@eisentraut.org>
<ZkP7ARo6lo90su3K@paquier.xyz>
On 15.05.24 02:00, Michael Paquier wrote:
> On Tue, May 14, 2024 at 10:39:36AM +0200, Peter Eisentraut wrote:
>> I saw the same thing. The problem is that there is incomplete dependency
>> information in the makefiles (not meson) between src/common/ and what is
>> using it. So whenever anything changes in src/common/, you pretty much have
>> to do a forced rebuild of everything.
>
> Is that a recent regression? I have some blurry memories from
> working on these areas that changing src/common/ reflected on the
> compiled pieces effectively at some point.
One instance of this problem that I can reproduce at least back to PG12 is
1. touch src/common/exec.c
2. make -C src/bin/pg_dump
This will rebuild libpgcommon, but it will not relink pg_dump.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, michael@paquier.xyz, alvherre@alvh.no-ip.org, jacob.champion@enterprisedb.com
Subject: Re: pgsql: Fix overread in JSON parsing errors for incomplete byte sequence
In-Reply-To: <bc57073e-27a3-4a4a-9d93-ef734d473a74@eisentraut.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox