From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Refactor dlopen() support
Date: Fri, 7 Sep 2018 18:27:28 +0200
Message-ID: <beaac5d2-33e4-0d60-5e7a-72fb034e35a9@2ndquadrant.com> (raw)
In-Reply-To: <3574.1536329946@sss.pgh.pa.us>
References: <E1fxqjl-0003YS-NS@gemulon.postgresql.org>
<14508.1536301857@sss.pgh.pa.us>
<765f9eb2-789c-59b2-c4c3-8ee865038b58@2ndquadrant.com>
<3574.1536329946@sss.pgh.pa.us>
On 07/09/2018 16:19, Tom Lane wrote:
> Somehow or other, the changes you made in dfmgr.c's #include lines
> have made it so that find_rendezvous_variable's local "bool found"
> variable is actually of type _Bool (which is word-wide on these
> machines). However, hash_search thinks its output variable is
> of type pointer to "typedef char bool". The proximate cause of
> the observed failure is that find_rendezvous_variable sees "found"
> as true when it should not, and thus fails to zero out the variable's
> value.
Ah because dlfcn.h includes stdbool.h. Hmm.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Refactor dlopen() support
In-Reply-To: <beaac5d2-33e4-0d60-5e7a-72fb034e35a9@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox