pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Teach verify_heapam() to validate update chains within a page.
Date: Wed, 22 Mar 2023 15:33:15 -0400
Message-ID: <bfa5bd2b-c0e6-9d65-62ce-97f4766b1c42@dunslane.net> (raw)
In-Reply-To: <E1peyL2-004pIC-0f@gemulon.postgresql.org>
References: <E1peyL2-004pIC-0f@gemulon.postgresql.org>


On 2023-03-22 We 09:17, Robert Haas wrote:
> Teach verify_heapam() to validate update chains within a page.
>
> Prior to this commit, we only consider each tuple or line pointer
> on the page in isolation, but now we can do some validation of a line
> pointer against its successor. For example, a redirect line pointer
> shouldn't point to another redirect line pointer, and if a tuple
> is HOT-updated, the result should be a heap-only tuple.
>
> Himanshu Upadhyaya and Robert Haas, reviewed by Aleksander Alekseev,
> Andres Freund, and Peter Geoghegan.


This has apparently broken one case in the buildfarm, which now fails an 
upgrade from REL9_2_STABLE because we run amcheck after the upgrade:


heap table "regression.public.xacttest", block 0, offset 1:
     non-heap-only update produced a heap-only tuple at offset 18
heap table "regression.public.xacttest", block 0, offset 2:
     non-heap-only update produced a heap-only tuple at offset 19
heap table "regression.public.xacttest", block 0, offset 4:
     non-heap-only update produced a heap-only tuple at offset 20
heap table "regression.public.xacttest", block 0, offset 5:
     non-heap-only update produced a heap-only tuple at offset 21
heap table "regression.public.wslot", block 0, offset 89:
     non-heap-only update produced a heap-only tuple at offset 95
heap table "regression.public.pslot", block 0, offset 95:
     non-heap-only update produced a heap-only tuple at offset 100
heap table "regression.public.pslot", block 0, offset 96:
     non-heap-only update produced a heap-only tuple at offset 101


I don't know if this is a bug in this commit or if the REL9_2_STABLE 
repo is really broken.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

view thread (4+ messages)  latest in thread

Message-ID: <bfa5bd2b-c0e6-9d65-62ce-97f4766b1c42@dunslane.net>
Permalink:  ../bfa5bd2b-c0e6-9d65-62ce-97f4766b1c42@dunslane.net/
Also on:    postgresql.org/message-id/bfa5bd2b-c0e6-9d65-62ce-97f4766b1c42@dunslane.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net, rhaas@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Teach verify_heapam() to validate update chains within a page.
  In-Reply-To: <bfa5bd2b-c0e6-9d65-62ce-97f4766b1c42@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox