From: David Steele <david@pgmasters.net>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Make WAL segment size configurable at initdb time.
Date: Fri, 9 Nov 2018 22:50:44 -0500
Message-ID: <d3c15820-562c-dcc4-5d4f-74550547e029@pgmasters.net> (raw)
In-Reply-To: <20181110033052.xmmozibdapwvenkx@alap3.anarazel.de>
References: <E1duXBW-0003QB-4d@gemulon.postgresql.org>
<68ea97d6-2ed9-f339-e57d-ab3a33caf3b1@pgmasters.net>
<20181005165447.zyzglieznybyi7wu@alap3.anarazel.de>
<fd0855d1-4bf5-65fc-9c0f-ff64af3061ab@pgmasters.net>
<f572c66f-1840-b789-04e2-b767f4765c3a@pgmasters.net>
<20181110033052.xmmozibdapwvenkx@alap3.anarazel.de>
On 11/9/18 10:30 PM, Andres Freund wrote:
> On 2018-11-09 21:45:18 -0500, David Steele wrote:
>> On 10/5/18 1:03 PM, David Steele wrote:
>>>
>>> So, while the WAL segment size used to be expressed in terms of 8K pages
>>> it is now expressed in terms of absolute bytes. This seemed to me to be
>>> a very deliberate change in the original commit so I guessed it was done
>>> for clarity, but that the docs didn't get the message.
>>
>> Thoughts on this?
>>
>> I know it's minor in the grand scheme of things but it caused me some
>> confusion when I was updating pgBackRest for v11 and I imagine it might
>> do the same for others.
>
> Sorry for forgetting this, pushed.
No worries. Thanks for pushing it.
> I kinda wonder whether we should move a few GUCs out of the
> <sect1 id="runtime-config-preset">
> section. Or adapt its description. Because a significant portion of its
> contents don't accurately seem to be described by
> The following <quote>parameters</quote> are read-only, and are determined
> when <productname>PostgreSQL</productname> is compiled or when it is
> installed.
> right?
I agree that "installed" is a bit vague.
Most of them are set at compile-time, some are set at initdb, and a few
are set at CREATE DATABASE.
I'm not sure about moving any out since it seems like "presets" fits the
bill. Maybe just break it up into three sections?
--
-David
david@pgmasters.net
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: david@pgmasters.net, andres@anarazel.de
Subject: Re: pgsql: Make WAL segment size configurable at initdb time.
In-Reply-To: <d3c15820-562c-dcc4-5d4f-74550547e029@pgmasters.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox