agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Alexander Lakhin <exclusion@gmail.com>
To: Amit Langote <amitlangote09@gmail.com>
To: Amit Langote <amitlan@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Invalidate RI fast-path metadata on operator family changes
Date: Sat, 19 Sep 2026 21:00:00 +0300
Message-ID: <e0258f8a-b8f5-411b-963f-5499afe78bf2@gmail.com> (raw)
In-Reply-To: <CA+HiwqHO2xu3eR6bZ99qSQgCTnoS9VC4e0KW25bxE5kmkRMGyQ@mail.gmail.com>
References: <E1x7p34-00000000Mv7-2O5S@gemulon.postgresql.org>
<CA+HiwqGitHCmO7nvV4nXXYWDkNYA+zVcJj=JNmL3C1O9B0Gz0A@mail.gmail.com>
<CA+HiwqHO2xu3eR6bZ99qSQgCTnoS9VC4e0KW25bxE5kmkRMGyQ@mail.gmail.com>
Hello Amit,
19.09.2026 12:14, Amit Langote wrote:
>> I noticed a few BF failures, after pushing the above changes:
>>
>> ...
>>
>> I don't see any relation between these failures and my commit. window
>> runs concurrently with foreign_key, but this commit's additions to the
>> latter are self-contained (a private operator family in its own
>> schema), so I don't see why window's plans would be affected.
>>
>> Does anyone see it differently?
> Forgot to add that the code change is isolated too in that it only
> changes what ri_triggers.c does on a pg_amop invalidation during an RI
> fast-path check, not anything the planner consults. It doesn't touch
> pg_constraint or how FKs feed planning, so I don't see a route from
> this commit's changes to these window plans. Any effect would be
> timing at most. I would not claim that I have figured this out.
I've reproduced such failures locally with:
test: test_setup
test: create_index
test: foreign_key window
x100
I think the window failures are caused by these additions:
+create operator family fam using btree;
+create operator class int_ops for type integer using btree family fam as
+ operator 1 <(integer,integer), operator 2 <=(integer,integer),
+ operator 3 =(integer,integer), operator 4 >=(integer,integer),
+ operator 5 >(integer,integer), function 1 btint4cmp(integer,integer);
Best regards,
Alexander
view thread (13+ messages) latest in thread
Message-ID: <e0258f8a-b8f5-411b-963f-5499afe78bf2@gmail.com>
Permalink: ../e0258f8a-b8f5-411b-963f-5499afe78bf2@gmail.com/
Also on: postgresql.org/message-id/e0258f8a-b8f5-411b-963f-5499afe78bf2@gmail.com
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: exclusion@gmail.com, amitlangote09@gmail.com, amitlan@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Invalidate RI fast-path metadata on operator family changes
In-Reply-To: <e0258f8a-b8f5-411b-963f-5499afe78bf2@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox