pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: TAP test for logical decoding on standby
3+ messages / 3 participants
[nested] [flat]
* pgsql: TAP test for logical decoding on standby
@ 2023-04-08 09:26 Andres Freund <andres@anarazel.de>
2023-05-23 15:15 ` Re: pgsql: TAP test for logical decoding on standby Robert Haas <robertmhaas@gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Andres Freund @ 2023-04-08 09:26 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
TAP test for logical decoding on standby
Author: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
Author: Amit Khandekar <amitdkhan.pg@gmail.com>
Author: Craig Ringer <craig@2ndquadrant.com> (in an older version)
Author: Andres Freund <andres@anarazel.de>
Reviewed-by: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
Reviewed-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Robert Haas <robertmhaas@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Reviewed-by: Fabrízio de Royes Mello <fabriziomello@gmail.com>
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/fcd77d53217b4c4049d176072a1763d6e11ca478
Modified Files
--------------
src/test/perl/PostgreSQL/Test/Cluster.pm | 37 ++
src/test/recovery/meson.build | 1 +
.../recovery/t/035_standby_logical_decoding.pl | 734 +++++++++++++++++++++
3 files changed, 772 insertions(+)
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: TAP test for logical decoding on standby
2023-04-08 09:26 pgsql: TAP test for logical decoding on standby Andres Freund <andres@anarazel.de>
@ 2023-05-23 15:15 ` Robert Haas <robertmhaas@gmail.com>
2023-05-24 11:58 ` Re: pgsql: TAP test for logical decoding on standby Drouvot, Bertrand <bertranddrouvot.pg@gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Robert Haas @ 2023-05-23 15:15 UTC (permalink / raw)
To: Andres Freund <andres@anarazel.de>; +Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>; Drouvot, Bertrand <bertranddrouvot.pg@gmail.com>
On Sat, Apr 8, 2023 at 5:26 AM Andres Freund <andres@anarazel.de> wrote:
> TAP test for logical decoding on standby
Small nitpicks:
1. The test names generated by check_slots_conflicting_status() start
with a capital letter, while most other test names start with a
lower-case letter.
2. The function is called 7 times, 6 with a true argument and 1 with a
false argument, but the test name only depends on whether the argument
is true or false, so we get the same test name 6 times. Maybe there's
not a reasonable way to do better, I'm not sure, but it's not ideal.
--
Robert Haas
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: TAP test for logical decoding on standby
2023-04-08 09:26 pgsql: TAP test for logical decoding on standby Andres Freund <andres@anarazel.de>
2023-05-23 15:15 ` Re: pgsql: TAP test for logical decoding on standby Robert Haas <robertmhaas@gmail.com>
@ 2023-05-24 11:58 ` Drouvot, Bertrand <bertranddrouvot.pg@gmail.com>
0 siblings, 0 replies; 3+ messages in thread
From: Drouvot, Bertrand @ 2023-05-24 11:58 UTC (permalink / raw)
To: Robert Haas <robertmhaas@gmail.com>; Andres Freund <andres@anarazel.de>; +Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Hi,
On 5/23/23 5:15 PM, Robert Haas wrote:
> On Sat, Apr 8, 2023 at 5:26 AM Andres Freund <andres@anarazel.de> wrote:
>> TAP test for logical decoding on standby
>
> Small nitpicks:
>
> 1. The test names generated by check_slots_conflicting_status() start
> with a capital letter, while most other test names start with a
> lower-case letter.
>
Yeah, not sure that would deserve a fix for its own but if we address 2.
then let's do 1. too.
> 2. The function is called 7 times, 6 with a true argument and 1 with a
> false argument, but the test name only depends on whether the argument
> is true or false, so we get the same test name 6 times. Maybe there's
> not a reasonable way to do better, I'm not sure, but it's not ideal.
>
I agree that's not ideal (but one could still figure out which one is
failing if any by looking at the perl script).
If we want to "improve" this, what about passing a second argument that
would provide more context in the test name?
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2023-05-24 11:58 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-04-08 09:26 pgsql: TAP test for logical decoding on standby Andres Freund <andres@anarazel.de>
2023-05-23 15:15 ` Robert Haas <robertmhaas@gmail.com>
2023-05-24 11:58 ` Drouvot, Bertrand <bertranddrouvot.pg@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox