From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Allow insert and update tuple routing and COPY for foreign table
Date: Mon, 22 Apr 2019 22:46:00 +0200
Message-ID: <f1e5a3f4b55c7006fd472900ea533b645ecb3050.camel@cybertec.at> (raw)
In-Reply-To: <CA+TgmoaAcNNpNO41yYu1afo1k3t9YoCd0LweYLthyo9LLHp_Ag@mail.gmail.com>
References: <E1f4aif-0004qo-A6@gemulon.postgresql.org>
<ed0b7471dce91169d871347cf003d8094ab96895.camel@cybertec.at>
<5CBDB770.2060602@lab.ntt.co.jp>
<b459d1b1b4eb8c0d538a2c5b70e131af3c391954.camel@cybertec.at>
<CA+TgmoaAcNNpNO41yYu1afo1k3t9YoCd0LweYLthyo9LLHp_Ag@mail.gmail.com>
On Mon, 2019-04-22 at 16:24 -0400, Robert Haas wrote:
> On Mon, Apr 22, 2019 at 3:37 PM Laurenz Albe <laurenz.albe@cybertec.at> wrote:
> > Sure, it is not hard to modify a FDW to continue working with v11.
> >
> > My point is that this should not be necessary.
>
> I'm not sure whether this proposal is a good idea or a bad idea, but I
> think that it's inevitable that FDWs are going to need some updating
> for new releases as the API evolves. That has happened before and
> will continue to happen.
Absolutely.
I am just unhappy that this change caused unnecessary breakage.
If you developed a read-only FDW for 9.2, it didn't break with the
write support introduced in 9.3, because that used different API
functions. That's how it should be IMHO.
If you developed a FDW for 9.1, it got broken in 9.2, because the
API had to change to allow returning multiple paths.
That was unfortunate but necessary, so it is ok.
Nothing in this patch required an incompatible change.
Yours,
Laurenz Albe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: laurenz.albe@cybertec.at, robertmhaas@gmail.com, fujita.etsuro@lab.ntt.co.jp, pgsql-committers@lists.postgresql.org, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Allow insert and update tuple routing and COPY for foreign table
In-Reply-To: <f1e5a3f4b55c7006fd472900ea533b645ecb3050.camel@cybertec.at>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox