From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
Cc: Robert Haas <rhaas@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Allow insert and update tuple routing and COPY for foreign table
Date: Thu, 25 Apr 2019 16:29:08 +0200
Message-ID: <fe47dddfbcb87c9a4a7605cc4f36b89eaef1e7b3.camel@cybertec.at> (raw)
In-Reply-To: <5CC1B358.5090205@lab.ntt.co.jp>
References: <E1f4aif-0004qo-A6@gemulon.postgresql.org>
<ed0b7471dce91169d871347cf003d8094ab96895.camel@cybertec.at>
<5CBDB770.2060602@lab.ntt.co.jp>
<b459d1b1b4eb8c0d538a2c5b70e131af3c391954.camel@cybertec.at>
<5CC04E72.90405@lab.ntt.co.jp>
<bf36a0288e8f31b4f2f40952e225bf892dc1ffc5.camel@cybertec.at>
<5CC1B358.5090205@lab.ntt.co.jp>
On Thu, 2019-04-25 at 22:17 +0900, Etsuro Fujita wrote:
> > The documentation of ExecForeignInsert should mention something like:
> >
> > ExecForeignInsert is called for INSERT statements as well
> > as for COPY FROM and tuples that are inserted into a foreign table
> > because it is a partition of a partitioned table.
> >
> > In the case of a normal INSERT, BeginForeignModify will be called
> > before ExecForeignInsert to perform any necessary setup.
> > In the other cases, this setup has to happen in BeginForeignInsert.
>
> These seem a bit redundant to me [...]
>
> OK, how about something like the attached? I reworded this a bit, though.
I like your patch better than my wording.
Thanks for the effort!
Yours,
Laurenz Albe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: laurenz.albe@cybertec.at, fujita.etsuro@lab.ntt.co.jp, rhaas@postgresql.org, pgsql-committers@lists.postgresql.org, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Allow insert and update tuple routing and COPY for foreign table
In-Reply-To: <fe47dddfbcb87c9a4a7605cc4f36b89eaef1e7b3.camel@cybertec.at>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox