From: Laurenz Albe <laurenz.albe@cybertec.at>
To: grantgryczan@gmail.com
To: pgsql-docs@lists.postgresql.org
Subject: Re: Incorrect grammar in 15.2
Date: Wed, 24 Jul 2024 12:52:25 +0200
Message-ID: <054ae54ad248783aefeb59813080d29faad5a11f.camel@cybertec.at> (raw)
In-Reply-To: <172179789219.915368.16590585529628354757@wrigleys.postgresql.org>
References: <172179789219.915368.16590585529628354757@wrigleys.postgresql.org>
On Wed, 2024-07-24 at 05:11 +0000, PG Doc comments form wrote:
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/16/when-can-parallel-query-be-used.html
> Description:
>
> Unless I'm misunderstanding the sentence structure here, I believe the word
> "a" is missing before "parallel query plan" in the following sentence from
> section 15.2:
>
> > Even when parallel query plan is generated for a particular query, there
> are several circumstances under which it will be impossible to execute that
> plan in parallel at execution time.
>
> This should say:
>
> > Even when a parallel query plan is generated for a particular query, there
> are several circumstances under which it will be impossible to execute that
> plan in parallel at execution time.
+1
Here is a patch for that; it may be the smallest patch I've ever
written for PostgreSQL.
Yours,
Laurenz Albe
Attachments:
[text/x-patch] v1-0001-Fix-a-missing-article-in-the-documentation.patch (1.0K, ../054ae54ad248783aefeb59813080d29faad5a11f.camel@cybertec.at/2-v1-0001-Fix-a-missing-article-in-the-documentation.patch)
download | inline diff:
From 68eedd01c754ffd2dfbb11cd29f568841d7db7a6 Mon Sep 17 00:00:00 2001
From: Laurenz Albe <laurenz.albe@cybertec.at>
Date: Wed, 24 Jul 2024 12:50:49 +0200
Subject: [PATCH v1] Fix a missing article in the documentation
Per complaint from Grant Gryczan.
---
doc/src/sgml/parallel.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/parallel.sgml b/doc/src/sgml/parallel.sgmlindex dae9dd7f2f..590cb385dd 100644--- a/doc/src/sgml/parallel.sgml+++ b/doc/src/sgml/parallel.sgml@@ -202,7 +202,7 @@ EXPLAIN SELECT * FROM pgbench_accounts WHERE filler LIKE '%x%';
</itemizedlist>
<para>
- Even when parallel query plan is generated for a particular query, there+ Even when a parallel query plan is generated for a particular query, there
are several circumstances under which it will be impossible to execute
that plan in parallel at execution time. If this occurs, the leader
will execute the portion of the plan below the <literal>Gather</literal>
--
2.45.2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: laurenz.albe@cybertec.at, grantgryczan@gmail.com, pgsql-docs@lists.postgresql.org
Subject: Re: Incorrect grammar in 15.2
In-Reply-To: <054ae54ad248783aefeb59813080d29faad5a11f.camel@cybertec.at>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox