From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jonathan S. Katz <jkatz@postgresql.org>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Pg Docs <pgsql-docs@lists.postgresql.org>
Subject: Re: Duplicating website's formatting in local doc builds
Date: Fri, 14 Feb 2020 18:06:18 -0500
Message-ID: <11007.1581721578@sss.pgh.pa.us> (raw)
In-Reply-To: <bd7e5ec0-caa4-56d0-562e-21880e205e02@postgresql.org>
References: <1375.1581446233@sss.pgh.pa.us>
<d381c45a-880f-7b0d-773d-be117685a6ad@postgresql.org>
<3873.1581449531@sss.pgh.pa.us>
<4b44c4ec-a678-6586-fbb0-efc3299af203@postgresql.org>
<CAH2-Wzka_NfJGfL9UvQ1Jau1gqerat2zR9O0iAm3DgQEAYebJQ@mail.gmail.com>
<dc3089b0-9c40-fc3b-bce1-7fcc16891dd1@postgresql.org>
<86f03290-e60c-855e-786a-d1b75c254811@postgresql.org>
<716a39ec-6f56-0280-8d4b-b246176c6a3d@postgresql.org>
<bd7e5ec0-caa4-56d0-562e-21880e205e02@postgresql.org>
"Jonathan S. Katz" <jkatz@postgresql.org> writes:
> To load the webfont, the "main.css" file uses a CSS "@import"
> instruction, which has a limitation that it can only be used as the top
> of the file. As main.css is not the first file in the "docs.csS"
> sandwich, it does not load.
> Buried in some version of the DocBook[1] documentation were in
> instructions on how to load in multiple stylesheets via
> <xsl:param name="html.stylesheet">
> which I followed in our XSLT, which lead to that portion of the diff.
It looks to me like the main text font now matches, but the font used for
<literal> text doesn't quite -- see the attached, and note for example the
capital T's in CREATE TYPE. (Local build with this patch on the left,
website on the right.) Still, it's enormously closer than before.
> Not included is one of Tom's original questions, which is should we just
> make using the website styles the default? As it stands, this would
> require network connectivity to preview the look for a page. If we want
> to ensure consistent views across the board, then I would say we import
> the stylesheets, knowing that "main.css" is volatile.
The point about network access seems to me to be sufficient reason not
to make it the default. I'd actually say that we ought to annotate
section J.3.1 to point out that "make STYLE=website" will result in
that. However, I'm not quite clear on whether that means external
access during viewing, or during build, or both? The note should say.
regards, tom lane
Attachments:table-comparison-v4.png (image/png, 718.8K) downloadview image
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: tgl@sss.pgh.pa.us, jkatz@postgresql.org, pg@bowt.ie, pgsql-docs@lists.postgresql.org
Subject: Re: Duplicating website's formatting in local doc builds
In-Reply-To: <11007.1581721578@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox