public inbox for [email protected]  

help / color / mirror / Atom feed

From: Jürgen Purtz <[email protected]>
To: Corey Huinker <[email protected]>
Cc: Justin Pryzby <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Roger Harkavy <[email protected]>
Cc: [email protected]
Cc: Fabien COELHO <[email protected]>
Cc: Michael Paquier <[email protected]>
Subject: Re: Add A Glossary
Date: Wed, 1 Apr 2020 09:34:41 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CADkLM=fwtE-TCU7sRnvaE74z12kOp_A+CdUwMr7aZt39pXbh6A@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CADkLM=eHCVmL8JnmaW2h+XXLRpKzkLrq6WXMbKB7giJCuS=jXA@mail.gmail.com>
	<[email protected]>
	<[email protected]>


On 31.03.20 19:58, Justin Pryzby wrote:
> On Tue, Mar 31, 2020 at 04:13:00PM +0200, Jürgen Purtz wrote:
>> Please find some minor suggestions in the attachment. They are based on
>> Corey's last patch 0001-glossary-v4.patch.
>> @@ -220,7 +220,7 @@
>>         Record</glossterm>s to the file system and creates a special
>>         checkpoint record. This process is initiated when predefined
>>         conditions are met, such as a specified amount of time has passed, or
>> -      a certain volume of records have been collected.
>> +      a certain volume of records has been collected.
> I think you're correct in that "volume" is singular.  But I think "collected"
> is the wrong world.  I suggested "written".
>
"collected" is not optimal. I suggest "created". Please avoid "written", 
the WAL records will be written when the Checkpointer is running, not 
before. So:

  "a certain volume of <glossterm>WAL records<glossterm> has been 
collected."


Every thing else is ok for me.

Kind regards, Jürgen

view thread (97+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Add A Glossary
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox