From: Simon Riggs <simon@2ndQuadrant.com>
To: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>
Cc: Aidan Van Dyk <aidan@highrise.ca>
Cc: Fujii Masao <masao.fujii@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL
Date: Thu, 11 Feb 2010 18:11:01 +0000
Message-ID: <1265911861.7341.2266.camel@ebony> (raw)
In-Reply-To: <4B743E7D.5070603@enterprisedb.com>
References: <3f0b79eb1002092105r21e009d3v468496058ba04392@mail.gmail.com>
<4B726120.80007@enterprisedb.com>
<1265884657.7341.1192.camel@ebony>
<4B73F678.8070109@enterprisedb.com>
<1265891248.7341.1346.camel@ebony>
<4B73FB99.4080403@enterprisedb.com>
<1265893599.7341.1454.camel@ebony>
<4B740613.5090004@enterprisedb.com>
<20100211140118.GB14128@oak.highrise.ca>
<4B74118C.30704@enterprisedb.com>
<20100211144204.GC14128@oak.highrise.ca>
<4B743E7D.5070603@enterprisedb.com>
On Thu, 2010-02-11 at 19:29 +0200, Heikki Linnakangas wrote:
> Aidan Van Dyk wrote:
> > * Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> [100211 09:17]:
> >
> >> Yeah, if you're careful about that, then this change isn't required. But
> >> pg_standby protects against that, so I think it'd be reasonable to have
> >> the same level of protection built-in. It's not a lot of code.
> >
> > This 1 check isn't, but what about the rest of the things pg_standby
> > does. How much functionality should we bring it? Ideally, "all" of it.
>
> Well, how about we bite the bullet then and add enough bells and
> whistles to the backend that pg_standby really isn't needed anymore, and
> remove it from contrib?
>
> Looking at the options to pg_standby, we're not missing much:
You're attitude to this makes me laugh, and cry.
Removing pg_standby can be done and if you manage it well, I would be
happy. I laugh because it seems like you think I have some ego tied up
in it. It's hardly my finest hour of coding, especially since I've not
had the ability to improve it much before now.
Not missing *much*?! I cry because you're so blase about missing one or
two essential features that took years to put in place. Keeping
pg_standby at least guarantees we can do something about it when we
discover you didn't do a good enough job removing it.
--
Simon Riggs www.2ndQuadrant.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: simon@2ndQuadrant.com, heikki.linnakangas@enterprisedb.com, aidan@highrise.ca, masao.fujii@gmail.com, pgsql-hackers@postgresql.org
Subject: Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL
In-Reply-To: <1265911861.7341.2266.camel@ebony>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox