public inbox for [email protected]  
help / color / mirror / Atom feed
From: Simon Riggs <[email protected]>
To: Robert Haas <[email protected]>
Cc: [email protected]
Subject: Re: [COMMITTERS] pgsql: Some copy-editing of the Hot Standby documentation.
Date: Fri, 25 Jun 2010 00:33:08 +0100
Message-ID: <1277422388.25074.11334.camel@ebony> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<1277413171.25074.10033.camel@ebony>
	<[email protected]>

On Thu, 2010-06-24 at 18:22 -0400, Robert Haas wrote:
> On Thu, Jun 24, 2010 at 4:59 PM, Simon Riggs <[email protected]> wrote:
> > On Thu, 2010-06-24 at 19:50 +0000, Robert Haas wrote:
> >> Log Message:
> >> -----------
> >> Some copy-editing of the Hot Standby documentation.
> >>
> >> Thanks to Joshua Tolley for the review.
> >
> > I rejected these changes. Please revoke.
> 
> Do you have the ability to unilaterally reject changes of which others approve?

Other(s)?? You mean your unilateral approval of your own work?

You should not commit if you do not have consensus.

There was no strong approval, though I expressed clearly my strong
disapproval. Regrettably, I found your changes added almost nothing and
were in many ways questionable.

> I think it's not very helpful to be trying to reject changes that
> people (yes, including me) take the time to make to the Hot Standby
> documentation.  The tone and style of that page do not match the tone
> and style of other parts of our documentation, and frankly I think it
> needs a lot more work than what I just did.  If every word that gets
> moved is going to turn into an argument, then no one will be willing
> to take the time to make any improvements at all, and I don't think
> that's good for the project.

So therefore we should accept everything *you* do in case there is a
fight? Perhaps you will agree to accept everything other people do as
well to encourage improvement? I don't really believe you want your
comments to be applied back to you, do you?

There is currently much documentation missing, especially around
Streaming Rep. It would be much better to spend your time adding that
than to contrive fights over changes that people disagreed with.

-- 
 Simon Riggs           www.2ndQuadrant.com




view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [COMMITTERS] pgsql: Some copy-editing of the Hot Standby documentation.
  In-Reply-To: <1277422388.25074.11334.camel@ebony>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox