pg.ddx.io pgsql-docs@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pg_dump no-owner option 2+ messages / 2 participants [nested] [flat]
* pg_dump no-owner option @ 2021-01-13 06:43 PG Doc comments form <noreply@postgresql.org> 0 siblings, 1 reply; 2+ messages in thread From: PG Doc comments form @ 2021-01-13 06:43 UTC (permalink / raw) To: pgsql-docs@lists.postgresql.org; +Cc: borisnov@acm.org The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/12/app-pgdump.html Description: Currently the documentation reads: This option is only meaningful for the plain-text format. This statement is imprecise. Actually the cownership has nothing to do with the format, it is equally meaningul to create a dump without ownership infomration for any format. Currently this is not possibel for any format except plain, as the option is ignored. So, the cited sentence should be replaced with 'This option is ignored for all formats except plain'. Would be much better to change the behavior of the utility to allow the option for all formats, but htis is somewhat more than just documentaion change. ^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: pg_dump no-owner option @ 2021-01-13 17:54 Tom Lane <tgl@sss.pgh.pa.us> parent: PG Doc comments form <noreply@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Tom Lane @ 2021-01-13 17:54 UTC (permalink / raw) To: borisnov@acm.org; +Cc: pgsql-docs@lists.postgresql.org PG Doc comments form <noreply@postgresql.org> writes: > Currently the documentation reads: > This option is only meaningful for the plain-text format. > This statement is imprecise. Yeah, I agree --- it's not clear whether the option is ignored or rejected. Explicitly saying it's ignored is an improvement. > Would be much better to change the behavior of the utility to allow the > option for all formats, but htis is somewhat more than just documentaion > change. I disagree that that would be an improvement. Per the next sentence that you omitted, the right time to apply this and similar options is when extracting data from the archive format. (pg_dump to text effectively constructs an archive dump in-memory and then extracts from that, so that its "back half" logic is identical to pg_restore's.) Filtering this info before dumping the archive would save no meaningful amount of space, while restricting how the archive could be used later. regards, tom lane ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2021-01-13 17:54 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-01-13 06:43 pg_dump no-owner option PG Doc comments form <noreply@postgresql.org> 2021-01-13 17:54 ` Re: pg_dump no-owner option Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox