From: Tom Lane <tgl@sss.pgh.pa.us>
To: borisnov@acm.org
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: pg_dump no-owner option
Date: Wed, 13 Jan 2021 12:54:20 -0500
Message-ID: <1288537.1610560460@sss.pgh.pa.us> (raw)
In-Reply-To: <161052021249.12228.9598689907884726185@wrigleys.postgresql.org>
References: <161052021249.12228.9598689907884726185@wrigleys.postgresql.org>
PG Doc comments form <noreply@postgresql.org> writes:
> Currently the documentation reads:
> This option is only meaningful for the plain-text format.
> This statement is imprecise.
Yeah, I agree --- it's not clear whether the option is ignored or
rejected. Explicitly saying it's ignored is an improvement.
> Would be much better to change the behavior of the utility to allow the
> option for all formats, but htis is somewhat more than just documentaion
> change.
I disagree that that would be an improvement. Per the next sentence that
you omitted, the right time to apply this and similar options is when
extracting data from the archive format. (pg_dump to text effectively
constructs an archive dump in-memory and then extracts from that, so that
its "back half" logic is identical to pg_restore's.) Filtering this info
before dumping the archive would save no meaningful amount of space, while
restricting how the archive could be used later.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: tgl@sss.pgh.pa.us, borisnov@acm.org, pgsql-docs@lists.postgresql.org
Subject: Re: pg_dump no-owner option
In-Reply-To: <1288537.1610560460@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox