From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
Cc: petermpallesen@gmail.com
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples
Date: Tue, 16 Jun 2020 10:08:14 -0400
Message-ID: <1300920.1592316494@sss.pgh.pa.us> (raw)
In-Reply-To: <20200616103644.GE31175@momjian.us>
References: <159195294959.673.5752624528747900508@wrigleys.postgresql.org>
<20200616103644.GE31175@momjian.us>
Bruce Momjian <bruce@momjian.us> writes:
> I have created the attached patch to mention
> suppress_redundant_updates_trigger() in this case. I don't think having
> an actual example is warranted.
I don't like this patch, because in fact
suppress_redundant_updates_trigger is entirely unrelated to the stated
purpose of that example (namely, to log something if the table was
changed). The way you've written it makes it sound like
suppress_redundant_updates_trigger could be used as an alternative
implementation of that requirement.
If you want to mention suppress_redundant_updates_trigger somewhere
in this area, that's fine, but it should be treated as an independent
topic rather than being wedged into the middle of an unrelated example.
Maybe a distinct para saying something like "To suppress no-op updates
of a table, see suppress_redundant_updates_trigger." (and making that
an actual link would be a good idea).
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: tgl@sss.pgh.pa.us, bruce@momjian.us, petermpallesen@gmail.com, pgsql-docs@lists.postgresql.org
Subject: Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples
In-Reply-To: <1300920.1592316494@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox