agora inbox for pgsql-docs@postgresql.org
help / color / mirror / Atom feedFrom: Tom Lane <tgl@sss.pgh.pa.us>
To: David G. Johnston <david.g.johnston@gmail.com>
Cc: alexey.shishkin@enterprisedb.com
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: correction suggestion for https://www.postgresql.org/docs/17/auth-username-maps.html
Date: Wed, 09 Jul 2025 15:30:04 -0400
Message-ID: <1341070.1752089404@sss.pgh.pa.us> (raw)
In-Reply-To: <CAKFQuwZu6kZ8ZPvJ3pWXig+6UX4nTVK-hdL_ZS3fSdps=RJQQQ@mail.gmail.com>
References: <175206279327.3157504.12519088928605422253@wrigleys.postgresql.org>
<CAKFQuwbhZg8C93_GU0WP=3qGuT0kbPsLL1htP-svrv=Bgjkpeg@mail.gmail.com>
<1145313.1752078127@sss.pgh.pa.us>
<CAKFQuwZu6kZ8ZPvJ3pWXig+6UX4nTVK-hdL_ZS3fSdps=RJQQQ@mail.gmail.com>
"David G. Johnston" <david.g.johnston@gmail.com> writes:
> Its good as far a narrow fix goes.
> But how about the attached? More invasive but covers the salient points
> better, IMO, and less repetitive than having the two fields have their own
> basically copy-pasted paragraphs.
Meh... I initially thought that merging the two paras sounded like a
good idea, but I'm not finding that this formulation reads any better.
Notably, as things stand we have parallel constructions
"If the <field> starts with an <x> character" in the preceding para as
well as these two, and I think it's good to keep that parallelism.
I do agree that it's overly repetitive, but we could improve that by
dropping the second instance of the parenthetical link to
posix-syntax-details.
> I didn't add an example but felt the point "be referenced a single time
> within" to be needed since, usefulness not withstanding, writing \1\1 for
> database-username works but only the first instance of \1 is replaced.
Hmm, I wonder if that isn't a bug we should fix. It's hard to believe
anyone is relying on the second \1 *not* getting replaced, and perhaps
there are use-cases for multiple replacements.
> Also, should we attempt to align this documentation and
> pg_ident.conf.sample as pertains to pg-username vs. database-username?
Agreed that making pg_ident.conf.sample match would be an improvement.
regards, tom lane
view thread (9+ messages) latest in thread
Message-ID: <1341070.1752089404@sss.pgh.pa.us>
Permalink: ../1341070.1752089404@sss.pgh.pa.us/
Also on: postgresql.org/message-id/1341070.1752089404@sss.pgh.pa.us
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: tgl@sss.pgh.pa.us, david.g.johnston@gmail.com, alexey.shishkin@enterprisedb.com, pgsql-docs@lists.postgresql.org
Subject: Re: correction suggestion for https://www.postgresql.org/docs/17/auth-username-maps.html
In-Reply-To: <1341070.1752089404@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox