From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jonathan S. Katz <jkatz@postgresql.org>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-docs@lists.postgresql.org, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Another modest proposal for docs formatting: catalog descriptions
Date: Sun, 10 May 2020 12:27:23 -0400
Message-ID: <14810.1589128043@sss.pgh.pa.us> (raw)
In-Reply-To: <3357.1589047741@sss.pgh.pa.us>
References: <20200506213810.GA29168@alvherre.pgsql>
<14800.1588805800@sss.pgh.pa.us>
<23610.1588978416@sss.pgh.pa.us>
<alpine.DEB.2.22.394.2005090847090.914063@pseudo>
<4521.1589038464@sss.pgh.pa.us>
<alpine.DEB.2.22.394.2005091912200.914063@pseudo>
<3357.1589047741@sss.pgh.pa.us>
Just FTR, here's a complete patch for this. I successfully regenerated
the column names, types, and ordering from the system catalogs, and
plugged the descriptions back into that by dint of parsing them out of
the XML. The "references" data was based on findoidjoins' results plus
hand additions to cover all the cases we are calling out now (there are
a lot of "references" links for attnums and a few other non-OID columns,
plus references links for views which findoidjoins doesn't consider).
So I have pretty high confidence that this info is OK. I'd be too
embarrassed to show anybody the code though ;-) ... it was just a brute
force hack.
regards, tom lane
Attachments:
catalog-reformat.patch.gz (application/x-gzip, 78.4K) downloadwebsite.patch (text/x-diff, 1.3K) download--- main.css~ 2020-05-10 12:18:39.773129302 -0400+++ main.css 2020-05-09 21:46:22.424776849 -0400@@ -792,13 +792,6 @@
}
/** Formatting for entries in tables of functions: indent all but first line **/
-#docContent table.table th.functableentry,-#docContent table.table td.functableentry {- padding-left: 4em;- text-indent: -3.5em;- text-align: left;-}-
#docContent table.table th.func_table_entry p,
#docContent table.table td.func_table_entry p {
margin-top: 0.1em;
@@ -820,6 +813,38 @@
padding-left: 4em;
}
+/** Formatting for entries in tables of catalog/view columns **/+#docContent table.table th.catalog_table_entry p,+#docContent table.table td.catalog_table_entry p {+ margin-top: 0.1em;+ margin-bottom: 0.1em;+ padding-left: 4em;+ text-align: left;+}++#docContent table.table th.catalog_table_entry p.column_definition {+ text-indent: -3.5em;+ word-spacing: 0.25em;+}++#docContent table.table td.catalog_table_entry p.column_definition {+ text-indent: -3.5em;+}++#docContent table.table p.column_definition code.type {+ padding-left: 0.25em;+ padding-right: 0.25em;+}++#docContent table.table td.catalog_table_entry pre.programlisting {+ background-color: inherit;+ border: 0;+ margin-bottom: 0.1em;+ margin-top: 0.1em;+ padding: 0;+ padding-left: 4em;+}+
/**
* Titles, Navigation
*/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: tgl@sss.pgh.pa.us, jkatz@postgresql.org, coelho@cri.ensmp.fr, alvherre@2ndquadrant.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Another modest proposal for docs formatting: catalog descriptions
In-Reply-To: <14810.1589128043@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox